Skip to content

[18.0][ADD] account_move_report_secondary_unit#410

Open
IriaAlonso wants to merge 1 commit into
OCA:18.0from
solvosci:18.0-add-account_move_report_secondary_unit
Open

[18.0][ADD] account_move_report_secondary_unit#410
IriaAlonso wants to merge 1 commit into
OCA:18.0from
solvosci:18.0-add-account_move_report_secondary_unit

Conversation

@IriaAlonso
Copy link
Copy Markdown

@IriaAlonso IriaAlonso commented May 7, 2026

Show the secondary unit of measure and the secondary quantity in invoice reports

@OCA-git-bot OCA-git-bot added series:18.0 mod:account_move_report_secondary_unit Module account_move_report_secondary_unit labels May 7, 2026
@IriaAlonso IriaAlonso force-pushed the 18.0-add-account_move_report_secondary_unit branch from 4280d89 to fb9690d Compare May 7, 2026 06:19
cgarcia-solvos
cgarcia-solvos reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown

@cgarcia-solvos cgarcia-solvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change, see comment.

Comment thread account_move_report_secondary_unit/report/report_invoice_document.xml Outdated
@IriaAlonso
[ADD] account_move_report_secondary_unit
089548c 
Show the secondary unit of measure and the secondary quantity in invoice reports
@IriaAlonso IriaAlonso force-pushed the 18.0-add-account_move_report_secondary_unit branch from fb9690d to 089548c Compare May 8, 2026 09:12
cgarcia-solvos
cgarcia-solvos approved these changes May 8, 2026
View reviewed changes
Copy link
Copy Markdown

@cgarcia-solvos cgarcia-solvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IriaAlonso
Copy link
Copy Markdown
Author

IriaAlonso commented May 14, 2026

@Saran440 @BhaveshHeliconia could you review it please?

BhaveshHeliconia
BhaveshHeliconia approved these changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review LGTM!

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 15, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@IriaAlonso
Copy link
Copy Markdown
Author

IriaAlonso commented May 28, 2026

@rafaelbn is this ready to be merged? Thanks!!

@yostashiro
Copy link
Copy Markdown
Member

yostashiro commented May 31, 2026

I believe the intent of the module overlaps with OCA/account-invoicing#2230, just so you are aware.

We have a set of PRs including the referenced one, that improve the usability of secondary units, but they depend on OCA/product-attribute#2211, which unfortunately hasn't received attention from the maintainer/PSC yet.

@yostashiro yostashiro mentioned this pull request May 31, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes

@cgarcia-solvos cgarcia-solvos cgarcia-solvos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:account_move_report_secondary_unit Module account_move_report_secondary_unit ready to merge series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IriaAlonso @OCA-git-bot @yostashiro @BhaveshHeliconia @cgarcia-solvos