[17.0][IMP] voip_oca: Update z-index for proper layering#347
[17.0][IMP] voip_oca: Update z-index for proper layering#347carlos-lopez-tecnativa wants to merge 1 commit intoOCA:17.0from
Conversation
|
Hi @etobella, |
|
At the same time you are there, can you please hide the systray icon when no voip provider is set in the user? |
| height: auto; | ||
| max-height: 70%; | ||
| z-index: 99; | ||
| z-index: 1001; |
There was a problem hiding this comment.
I would say this z-index is on purpose for not being on top on certain cases, isn't it @etobella ?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
pedrobaeza
removed
the
stale
|
Could you try to show what happens if we open a readonly O2M line or opening a wizard? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
pedrobaeza
removed
the
stale
When the web_responsive module is installed, the VoIP component is not displayed in the main menu because web_responsive has a higher z-index. https://github.com/OCA/web/blob/32184c6f6b6c34a2660e4adbe8271f2021f22bdf/web_responsive/static/src/components/apps_menu/apps_menu.scss#L35 After this commit, the VoIP component will always be displayed.
Opening a wizard Opening an O2M (in the sale order, for example, I manually edited it to remove the editable attribute so I could open the line) |
carlos-lopez-tecnativa
force-pushed
the
17.0-imp-voip_oca
branch
from
20df5dc to
cd4cbfd
Compare
4 participants
When the
web_responsivemodule is installed, the VoIP component is not displayed in the main menu becauseweb_responsivehas a higher z-index.Before
voip_oca_before.mp4
After this commit, the VoIP component will always be displayed.
voip_oca_after.mp4
@Tecnativa @pedrobaeza @etobella could you please review this?