-
-
Notifications
You must be signed in to change notification settings - Fork 459
draft: [16.0][ADD] connector_amazon_spapi #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
718a5ff to
407c2a8
Compare
78a8b27 to
77dbab3
Compare
|
Hi @dnplkndll ! FYI I started an Amazon connector in 2023-2024 with another strategy : I never finished it because the clients didn't have the budget anymore, but the idea was to be based on the OCA/sale-channel modules and the python-amazon-sp-api library instead of rewriting all the connection and importation code in one big module. (my PR is a bit messy because it is based on a akretion/sale-import repo and these base modules are now on OCA/sale-channel repo... but I hope you get the idea :) ) Another difference I notice is that you don't make the difference between Seller (selling to customers through Amazon) and Vendor (selling to Amazon) as Amazon does. It seems important to incorporate this logic in 3 different modules (base/vendor/seller). Finally, I notice that you chose to recreate the whole sale.order(.line) logic with this amazon.sale.order(.line) model to handle the imported order's data before creating the real sale.order, while we used the "sale.import.payload" model, which only contains the raw payload data as a big string, before creating the Odoo sale.order. (in my messy PR I use the "queue.job.chunk" model, which was part of a separated module, but which is now included in the sale_import_base module, and renamed "sale.import.payload"). I admit this approach might be less user friendly, but it seems more robust... and might save more than 700 lines of code. what do you think? |
|
Thanks for sharing, that’s useful context 👍 |
|
we have a bit of spaghetti already . the have to do all the PRs on all the other projects get approved. deal with 100+ PR in gitagg in the mean time. mixed feelings on the subject but would love to discuss. I do not currently have the use case to test the FBA but ready to fo on amazon testing and was hoping to consolidate the missing parts like the pull or push competitor price match since the comparables live in seller central. then managing this as one of 3 channels I need to presever stock in total to customer in one of 5 sites in addition to market here. but other customer buying in regular versus sell on amazon until someone else gets the buy box is not the goal. |
|
Hi @jelenapoblet! Ok to be part of the OCA's Discord channel, my username is clementmbr there too. I just won't have a lot of time to work on the topic, but happy to share what I've made and understood so far. |
|
Here's the link to the discord channel: https://discord.gg/GDz3kPse |
572915a to
7a57a87
Compare
|
All GET requests are tested, no POST request is tested yet, but I am willing to get a volunteer to sacrifice himself for others to survive :) |

No description provided.