[18.0][IMP] delivery_ups_oca: add token refresh#1190
Open
KDRdev wants to merge 1 commit into
Open
Conversation
KDRdev
force-pushed
the
18.0-imp-add-token-refresh
branch
from
86da059 to
ca3fd7e
Compare
|
@carlos-lopez-tecnativa it would be great if you could review this. |
carlos-lopez-tecnativa
suggested changes
May 29, 2026
| self._get_new_token() | ||
| status = self._send_request(url, json, data, headers, method) | ||
| status = status.json() | ||
| headers["Authorization"] = f"Bearer {self.token}" |
Contributor
There was a problem hiding this comment.
Is this change the only code that actually does something?
All the remaining code is only adding debug logging. If that is correct, then to minimize the diff and avoid logging this data, please remove all code related to logging.
Author
There was a problem hiding this comment.
You mean it's better to create a separate PR for logging? I think it's still needed, but would gladly read your opinion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.