[17.0][MIG] helpdesk_mgmt_sla: Migration to 17.0 #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 90.0% (27 of 30 strings) Translation: helpdesk-13.0/helpdesk-13.0-helpdesk_mgmt_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-13-0/helpdesk-13-0-helpdesk_mgmt_sla/es/
Currently translated at 100.0% (30 of 30 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_sla/es_AR/
Implement more advanced rules to filter the tickets it applies to. Additionally, the stage_id field is removed as it wasn't used.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_sla/
Currently translated at 100.0% (73 of 73 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_sla/es_AR/ Added translation using Weblate (Italian)
Currently translated at 100.0% (73 of 73 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_sla/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_sla/
Currently translated at 100.0% (72 of 72 strings) Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt_sla/it/
Currently translated at 100.0% (69 of 69 strings) Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt_sla Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt_sla/pt_BR/
hoangtrann
force-pushed
the
17.0-mig-helpdesk_mgmt_sla
branch
from
2877bf8 to
f3c6c5b
Compare
hoangtrann
force-pushed
the
17.0-mig-helpdesk_mgmt_sla
branch
from
f3c6c5b to
7a95550
Compare
Author
|
@marcelsavegnago could you have a look? |
rrebollo
approved these changes
Oct 16, 2025
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <odoo noupdate="0"> | |||
There was a problem hiding this comment.
Suggested change
| <odoo noupdate="0"> | |
| <odoo> |
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <odoo noupdate="0"> | |||
| <record id="helpdesk_mgmt.helpdesk_team_2" model="helpdesk.ticket.team"> | |||
There was a problem hiding this comment.
Suggested change
| <record id="helpdesk_mgmt.helpdesk_team_2" model="helpdesk.ticket.team"> | |
| <record id="helpdesk_team_2" model="helpdesk.ticket.team"> |
| break | ||
|
|
||
| def check_ticket_sla(self, tickets): | ||
| for ticket in tickets: |
There was a problem hiding this comment.
Suggested change
| for ticket in tickets: | |
| self.ensure_one() | |
| for ticket in tickets: |
| class HelpdeskTicket(models.Model): | ||
| _inherit = "helpdesk.ticket" | ||
|
|
||
| team_sla = fields.Boolean(string="Team SLA", compute="_compute_team_sla") |
There was a problem hiding this comment.
Suggested change
| team_sla = fields.Boolean(string="Team SLA", compute="_compute_team_sla") | |
| team_sla = fields.Boolean(string="Team SLA", related="team_id.use_sla") |
Comment on lines
+14
to
+16
| def _compute_team_sla(self): | ||
| for rec in self: | ||
| rec.team_sla = rec.team_id.use_sla |
There was a problem hiding this comment.
Suggested change
| def _compute_team_sla(self): | |
| for rec in self: | |
| rec.team_sla = rec.team_id.use_sla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.