Skip to content

[19.0][MIG] hr_expense_employee_analytic_default: Migration to 19.0#350

Draft
dnplkndll wants to merge 5 commits into
OCA:19.0from
ledoent:19.0-mig-hr_expense_employee_analytic_default
Draft

[19.0][MIG] hr_expense_employee_analytic_default: Migration to 19.0#350
dnplkndll wants to merge 5 commits into
OCA:19.0from
ledoent:19.0-mig-hr_expense_employee_analytic_default

Conversation

@dnplkndll
Copy link
Copy Markdown

@dnplkndll dnplkndll commented May 25, 2026

Port of hr_expense_employee_analytic_default to 19.0.

Non-mechanical adaptations worth flagging

  • Odoo 19 Support: Adapted the _get_distribution override inside models/account_analytic_distribution_model.py to check both address_id and work_contact_id for resolving default employee analytic cost-centers.
  • Unit Tests: Completely rewrote the test suite to use standard Odoo 19 transaction patterns, ensuring direct and robust employee-analytic mapping test cases.

@OCA-git-bot OCA-git-bot added series:19.0 mod:hr_expense_employee_analytic_default Module hr_expense_employee_analytic_default labels May 25, 2026
@dnplkndll dnplkndll force-pushed the 19.0-mig-hr_expense_employee_analytic_default branch from 34d7768 to fc07400 Compare May 25, 2026 14:25
@dnplkndll dnplkndll force-pushed the 19.0-mig-hr_expense_employee_analytic_default branch from fc07400 to a94306c Compare May 25, 2026 19:07
@dnplkndll dnplkndll force-pushed the 19.0-mig-hr_expense_employee_analytic_default branch from a94306c to 058904e Compare May 29, 2026 01:20

class TestHrExpenseEmployeeAnalyticDefault(BaseCommon):
@tagged("post_install", "-at_install")
class TestHrExpenseEmployeeAnalyticDefault(TransactionCase):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why these changes are needed?

@@ -1,21 +1,45 @@
# Copyright 2024 Tecnativa - Víctor Martínez
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why these changes are needed?

@dnplkndll dnplkndll force-pushed the 19.0-mig-hr_expense_employee_analytic_default branch from 058904e to 8f6e51f Compare June 2, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:hr_expense_employee_analytic_default Module hr_expense_employee_analytic_default series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants