Skip to content

[19.0][MIG] hr_expense_tax_distribution: Migration to 19.0#351

Draft
dnplkndll wants to merge 3 commits into
OCA:19.0from
ledoent:19.0-mig-hr_expense_tax_distribution
Draft

[19.0][MIG] hr_expense_tax_distribution: Migration to 19.0#351
dnplkndll wants to merge 3 commits into
OCA:19.0from
ledoent:19.0-mig-hr_expense_tax_distribution

Conversation

@dnplkndll
Copy link
Copy Markdown

@dnplkndll dnplkndll commented May 25, 2026

Port of hr_expense_tax_distribution to 19.0.

Non-mechanical adaptations worth flagging

  • Sheetless Tax Distribution: Refactored the module to calculate tax splits directly on lines, overriding _prepare_receipts_vals() and _prepare_payments_vals() on hr.expense to bypass the completely removed hr.expense.sheet core model.
  • Test Modernisation: Replaced legacy sheet workflows and action calls in unit tests with direct line submission and direct posting (_post_without_wizard).
  • Standardization: Updated all translations to use the new self.env._() pattern and wrapped long lines to pass the OCA ruff checks.

@OCA-git-bot OCA-git-bot added series:19.0 mod:hr_expense_tax_distribution Module hr_expense_tax_distribution labels May 25, 2026
@dnplkndll dnplkndll force-pushed the 19.0-mig-hr_expense_tax_distribution branch from 4f05f21 to 35d1f0b Compare May 25, 2026 14:25
@dnplkndll dnplkndll changed the title [19.0][ADD] hr_expense_tax_distribution [19.0][MIG] hr_expense_tax_distribution: Migration to 19.0 May 25, 2026
@dnplkndll dnplkndll force-pushed the 19.0-mig-hr_expense_tax_distribution branch from 35d1f0b to f18cfef Compare May 25, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:hr_expense_tax_distribution Module hr_expense_tax_distribution series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants