[19.0][MIG] hr_employee_id: Migration to 19.0#1509
Open
bizzappdev wants to merge 39 commits into
Open
Conversation
…Management modules
Initial Attempt of a port to V8 Some improvements made are as follows: * Ability so choose ID generation method * Sequence vs Random hr_employee_id: code linting and copyright removals apply suggeste changes * Use identification_id provided by hr addon rather than employee_no * use new api in configuration * pep8 changes Update res_company.py make fields assignable from res_company add tests Remove duplicate license key import openerp.exception.Warning as UserWarning [FIX] import Warning as UserWarning
* Change .py header according OCA simple header * Add parameter name on field declaration * Greenify travis * Modify README.rst. Removing tabs from xml * Remove space from xml files * Make module installable
Currently translated at 53.3% (8 of 15 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/ar/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/es/
Currently translated at 81.2% (13 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/de/
Currently translated at 81.2% (13 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/hr/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-12.0/hr-12.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_id/pt_BR/
o test default values even when company fields are false o test multi-company correctness
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-15.0/hr-15.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-15.0/hr-15.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/it/
Currently translated at 100.0% (16 of 16 strings) Translation: hr-15.0/hr-15.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_employee_id/it/
- Updated the create method in models/hr_employee.py to not break batch mode create
- Add test : test_generate_identification_id_exception
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-16.0/hr-16.0-hr_employee_id Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_id/
vedant-agravat
approved these changes
Dec 9, 2025
|
Code and functional review: LGTM. |
Member
|
/ocabot migration hr_employee_id |
alexey-pelykh
approved these changes
Feb 28, 2026
Contributor
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for the 19.0 migration! As the original author — this looks good. The employee ID generation logic and company-wide uniqueness constraint are preserved correctly.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.