Skip to content

[19.0] [MIG] hr_personal_equipment_request: Migration to 19.0#1530

Open
BhaveshHeliconia wants to merge 36 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-hr_personal_equipment_request
Open

[19.0] [MIG] hr_personal_equipment_request: Migration to 19.0#1530
BhaveshHeliconia wants to merge 36 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-hr_personal_equipment_request

Conversation

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia commented Dec 19, 2025

No description provided.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 19.0-mig-hr_personal_equipment_request branch from 94b7783 to 9f7c1e5 Compare December 19, 2025 08:35
This was referenced Dec 19, 2025
Open
Open
@percevaq
Copy link
Copy Markdown

percevaq commented Feb 2, 2026

LGTM

@BhaveshHeliconia
Copy link
Copy Markdown
Contributor Author

BhaveshHeliconia commented Feb 11, 2026

@percevaq Thanks for reviewing the PR. However, comments alone don’t mark the PR as approved. To approve it, please go to the Files changed tab, click the green Review changes button, select Approve if everything looks fine, and then submit. That’s the process to approve a PR.

alexey-pelykh
alexey-pelykh approved these changes Feb 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the migration! Code review looks clean — the allocation workflow states, security rules, and views all carry over properly to 19.0. LGTM

albariera and others added 24 commits March 13, 2026 09:43
@albariera @BhaveshHeliconia
[ADD] hr_personal_equipment: added module to manage employee personal…
b46631f 
… equipment
@albariera @BhaveshHeliconia
[IMP] hr_personal_equipment_request: black, isort, prettier
41c8047
@albariera @BhaveshHeliconia
[MIG] hr_personal_equipment_request: Migration to 13.0
6b7fe3b
@albariera @BhaveshHeliconia
[IMP] hr_personal_equipment_request: add smart button to allocations …
5302f23 
…from request
@BhaveshHeliconia
[MIG] hr_personal_equipment_request: Migration to 14.0
169960c
@albariera @BhaveshHeliconia
[IMP] hr_personal_equipment_request: add colors depending on state to…
ae2e2ee 
… tree view
@rafamarpe @BhaveshHeliconia
Added translation using Weblate (Spanish)
bf9f38c
@rafamarpe @BhaveshHeliconia
Added translation using Weblate (Spanish)
384566a
@rafamarpe @BhaveshHeliconia
Translated using Weblate (Spanish)
f2de65a 
Currently translated at 98.7% (81 of 82 strings)

Translation: hr-14.0/hr-14.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_personal_equipment_request/es/
@rafamarpe @BhaveshHeliconia
Translated using Weblate (Spanish)
e267825 
Currently translated at 98.7% (81 of 82 strings)

Translation: hr-14.0/hr-14.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_personal_equipment_request/es/
@rafamarpe @BhaveshHeliconia
Translated using Weblate (Spanish)
d2f9666 
Currently translated at 98.7% (81 of 82 strings)

Translation: hr-14.0/hr-14.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_personal_equipment_request/es/
@rafamarpe @BhaveshHeliconia
Translated using Weblate (Spanish)
a71ff8e 
Currently translated at 98.7% (81 of 82 strings)

Translation: hr-14.0/hr-14.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_personal_equipment_request/es/
@marylla @BhaveshHeliconia
Added translation using Weblate (German)
c6f804f
@olgamarcocb @BhaveshHeliconia
[MIG] hr_personal_equipment_request: Migration to 15.0
b07e9d4
@douglascstd @BhaveshHeliconia
Added translation using Weblate (Portuguese (Brazil))
1da4ea3
@douglascstd @BhaveshHeliconia
Translated using Weblate (Portuguese (Brazil))
483e6e9 
Currently translated at 30.0% (24 of 80 strings)

Translation: hr-15.0/hr-15.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_personal_equipment_request/pt_BR/
@FernandoRomera @BhaveshHeliconia
[16.0][MIG] hr_personal_equipment_request: Migration to 16.0
fe23df7
@mymage @BhaveshHeliconia
Added translation using Weblate (Italian)
8976a82
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
1fb02dc 
Currently translated at 100.0% (75 of 75 strings)

Translation: hr-16.0/hr-16.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_personal_equipment_request/it/
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
cc88eec 
Currently translated at 100.0% (75 of 75 strings)

Translation: hr-16.0/hr-16.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_personal_equipment_request/it/
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
1655d89 
Currently translated at 100.0% (75 of 75 strings)

Translation: hr-16.0/hr-16.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_personal_equipment_request/it/
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
25d6cda 
Currently translated at 98.6% (75 of 76 strings)

Translation: hr-16.0/hr-16.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_personal_equipment_request/it/
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
242e20e 
Currently translated at 100.0% (76 of 76 strings)

Translation: hr-16.0/hr-16.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_personal_equipment_request/it/
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
23233e5 
Currently translated at 100.0% (76 of 76 strings)

Translation: hr-16.0/hr-16.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_personal_equipment_request/it/
Ivorra78 and others added 11 commits March 13, 2026 09:43
@Ivorra78 @BhaveshHeliconia
Translated using Weblate (Spanish)
68f4b65 
Currently translated at 100.0% (76 of 76 strings)

Translation: hr-16.0/hr-16.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_personal_equipment_request/es/
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
e2765c0 
Currently translated at 100.0% (76 of 76 strings)

Translation: hr-16.0/hr-16.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_personal_equipment_request/it/
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
ce37f1e 
Currently translated at 100.0% (76 of 76 strings)

Translation: hr-16.0/hr-16.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_personal_equipment_request/it/
@Ivorra78 @BhaveshHeliconia
Translated using Weblate (Spanish)
6a5b224 
Currently translated at 100.0% (76 of 76 strings)

Translation: hr-16.0/hr-16.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_personal_equipment_request/es/
@Ivorra78 @BhaveshHeliconia
Translated using Weblate (Spanish)
7a89b14 
Currently translated at 100.0% (76 of 76 strings)

Translation: hr-16.0/hr-16.0-hr_personal_equipment_request
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_personal_equipment_request/es/
@BhaveshHeliconia
[MIG] hr_personal_equipment_request: Migration to 17.0
2d68597
@BhaveshHeliconia
[IMP] hr_personal_equipment_request: pre-commit auto fixes
5462b85
@BhaveshHeliconia
[MIG] hr_personal_equipment_request: Migration to 18.0
0516815
@BhaveshHeliconia
[UPD] Update hr_personal_equipment_request.pot
98d2914
@OCA-git-bot @BhaveshHeliconia
[BOT] post-merge updates
bc203c2
@BhaveshHeliconia
[IMP] hr_personal_equipment_request: pre-commit auto fixes
e0f0d0a
@BhaveshHeliconia BhaveshHeliconia force-pushed the 19.0-mig-hr_personal_equipment_request branch from 9f7c1e5 to 35de3dd Compare March 13, 2026 04:13
WesleyOliveira98
WesleyOliveira98 approved these changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown

@WesleyOliveira98 WesleyOliveira98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcelsavegnago
marcelsavegnago approved these changes Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelsavegnago
Copy link
Copy Markdown
Member

marcelsavegnago commented Jun 1, 2026

ping @etobella

etobella
etobella reviewed Jun 1, 2026
View reviewed changes
Comment thread hr_personal_equipment_request/models/hr_personal_equipment.py Outdated
}
}

domain = []
Copy link
Copy Markdown
Member

@etobella etobella Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this domain could be handled directly inside the view. that would be cleaner....

Copy link
Copy Markdown
Contributor Author

@BhaveshHeliconia BhaveshHeliconia Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have refactored the dynamic domain filtering for product_uom_id following Odoo 19.

Copy link
Copy Markdown
Member

@etobella etobella Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but onchange are not required, it is better to use compute and handle the domain directly in the view

Copy link
Copy Markdown
Contributor Author

@BhaveshHeliconia BhaveshHeliconia Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I've replaced the onchange method with a stored, editable compute field and updated the unit tests.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 19.0-mig-hr_personal_equipment_request branch from 35de3dd to fbbbe90 Compare June 2, 2026 04:10
@OCA-git-bot OCA-git-bot added series:19.0 mod:hr_personal_equipment_request Module hr_personal_equipment_request labels Jun 2, 2026
@BhaveshHeliconia BhaveshHeliconia force-pushed the 19.0-mig-hr_personal_equipment_request branch from fbbbe90 to c060a42 Compare June 2, 2026 07:12
@BhaveshHeliconia BhaveshHeliconia requested a review from etobella June 3, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

@etobella etobella Awaiting requested review from etobella

+2 more reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@WesleyOliveira98 WesleyOliveira98 WesleyOliveira98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:hr_personal_equipment_request Module hr_personal_equipment_request series:19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.