Skip to content

[FIX] hr_employee_firstname: remove address_home_id (removed in v19) #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mraimou wants to merge 1 commit into
base: 19.0
Choose a base branch
from
Open

[FIX] hr_employee_firstname: remove address_home_id (removed in v19) #1556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hr_employee_firstname/models/hr_employee.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

_logger = logging.getLogger(__name__)

UPDATE_PARTNER_FIELDS = ["firstname", "lastname", "user_id", "address_home_id"]
UPDATE_PARTNER_FIELDS = ["firstname", "lastname", "user_id"]


class HrEmployee(models.Model):
Expand Down Expand Up @@ -171,7 +171,7 @@ def _install_employee_firstname(self):
def _update_partner_firstname(self):
for employee in self:
partners = employee.mapped("user_id.partner_id")
partners |= employee.mapped("address_home_id")
# address_home_id removed in v19 — private address is no longer a res.partner
Copy link
Copy Markdown

@AnizR AnizR Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# address_home_id removed in v19 — private address is no longer a res.partner

No need to add a comment

partners.write(
{"firstname": employee.firstname, "lastname": employee.lastname}
)
Expand Down
Loading