[18.0][MIG] hr_announcement: Migration to 18.0#1582
Open
ManfredNelvin-Dev wants to merge 13 commits into
Open
Conversation
Currently translated at 100.0% (9 of 9 strings) Translation: hr-15.0/hr-15.0-hr_announcement Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_announcement/it/
Currently translated at 100.0% (9 of 9 strings) Translation: hr-15.0/hr-15.0-hr_announcement Translate-URL: https://translation.odoo-community.org/projects/hr-15-0/hr-15-0-hr_announcement/es/
Member
|
What about #1549? Did you check the problem depicted there? |
Member
|
/ocabot migration hr_announcement |
Author
|
Hi @pedrobaeza Yes, I reviewed #1549. The issue reported there was the use of vals_list.get("employee_ids") in the create() override, which is incorrect because vals_list is a list when using @api.model_create_multi. In this PR, that has been fixed by checking: The Odoo and OCB test suites are also passing successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to 18.0