[19.0][MIG] account_banking_ach_base: Migration to 19.0#178
Draft
dnplkndll wants to merge 23 commits into
Draft
Conversation
OCA-git-bot
added
series:19.0
mod:account_banking_ach_base
dnplkndll
force-pushed
the
19.0-mig-account_banking_ach_base
branch
2 times, most recently
from
e64f7bc to
ccb0de1
Compare
Co-authored-by: Daniel Reis <dreis@opensourceintegrators.com>
…xcept space,comma and underscore because these special characters are accepted while creating a file
[FIX] account_banking_ach_base: use the payment_ids field instead of bank_line_ids Applies same fix as OCA#101 amount_currency no longer available in 16 (Changed to amount) communicaton field no longer available in 16 (Changed to ref)
Closes the missing-tests/ HIGH finding from the OCA review. Adds 4 test methods covering the module's three pieces of value: 1. res.bank.routing_number US RTN format constraint - test_us_routing_number_valid (122000661, Wells Fargo, passes stdnum) - test_us_routing_number_invalid_raises (000000000 → ValidationError) - test_ca_routing_number_format (8 digits OK, 7 digits → ValidationError) 2. account.banking.mandate.delay_days enforcement - test_mandate_validate_requires_delay_days (delay_days=0 → UserError) Each test uses the smallest scaffold required (TransactionCase, base.us / base.ca, ad-hoc res.partner.bank) — no AccountTestInvoicingCommon, no full chart-of-accounts setup. Total: ~80 lines.
dnplkndll
force-pushed
the
19.0-mig-account_banking_ach_base
branch
from
ccb0de1 to
3403de3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of account_banking_ach_base to Odoo 19.0. Depends on #177.