Refactoring post init hook#15
Open
rfindling-gpc wants to merge 1 commit into
Open
Conversation
Refactor contact matching to use SQL queries for efficiency. Added logging for updated mailing contacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the post_init_hook function in mass_mailing_partner/hooks.py to replace Python-based contact-partner matching with SQL queries for improved performance. The changes aim to efficiently match mailing contacts to partners by email and synchronize their category tags using direct database operations instead of ORM iterations.
Changes:
Context:
We tried to initiate the app with previous mass mailing history, but mass_mailing_partner attempts to link historical mass mailing statistics (opens, clicks, bounces) to partners during installation. Without this step, only new contacts/statistics would be linked after installation, but this module tries to include historical data so reporting is complete from day one. The problem is that the linking function is inefficient: it processes records one by one. Since there are many records, the installation hits Odoo.sh time limits and fails.