[18.0][FIX] mass_mailing_list_dynamic: optimize sync operations

[yajo]

Now there is only 1 ORM operation per list and 1 global unlink of garbage
contacts at the end.

@moduon MT-13677

[chienandalu]

Looking good 👍

[Shide]

Code review

[pedrobaeza]

Thanks for improving the performance. The only problem I see with this is that the recordset operations creates a new recordset, so they are not very good at performance. Alternatives are to store a set of IDs instead.

[yajo]

The only problem I see with this is that the recordset operations creates a new recordset, so they are not very good at performance

Thanks for the pointer. However, these are the most impactful performance problems:

1. Field assignment triggers constraints:

   mass-mailing/mass_mailing_list_dynamic/models/mailing_list.py

   Line 50 in 0d06669

   one.contact_ids -= contact_to_detach

   (this is related to [FIX] mass_mailing_partner: optimize duplicates check and error message #17 where the constraint triggered a flush because of a search within).
2. Unlink triggers flushes:

   mass-mailing/mass_mailing_list_dynamic/models/mailing_list.py

   Line 51 in 0d06669

   contact_to_detach.filtered(lambda r: not r.list_ids).unlink()

3. Create too:

   mass-mailing/mass_mailing_list_dynamic/models/mailing_list.py

   Line 65 in 0d06669

   Contact.create(vals_list)

Removing those problems, the difference between in-memory recordsets or in-memory lists of IDs becomes irrelevant, while making the code easier to maintain.

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-16-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[OCA-git-bot]

Congratulations, your PR was merged at 71c5c12. Thanks a lot for contributing to OCA. ❤️