Skip to content

[FIX] mass_mailing_partner: optimize duplicates check and error message #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yajo wants to merge 1 commit into from
Closed

[FIX] mass_mailing_partner: optimize duplicates check and error message #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions mass_mailing_partner/models/mailing_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,19 @@ class MailingList(models.Model):

@api.constrains("contact_ids")
def _check_contact_ids_partner_id(self):
contact_obj = self.env["mailing.contact"]
failures = self.env["mailing.contact"]
for mailing_list in self:
data = contact_obj.read_group(
[
("id", "in", mailing_list.contact_ids.ids),
("partner_id", "!=", False),
],
["partner_id"],
["partner_id"],
)
if len(list(filter(lambda r: r["partner_id_count"] > 1, data))):
raise ValidationError(
self.env._("A partner cannot be multiple times " "in the same list")
partners = self.env["res.partner"]
for contact in mailing_list.contact_ids:
if contact.partner_id:
if contact.partner_id in partners:
failures |= contact
partners |= contact.partner_id
if failures:
raise ValidationError(
self.env._(
"A partner cannot be multiple times in the same list. "
"Failed contacts:\n - %s",
"\n- ".join(failures.mapped(lambda c: f"{c.name} ({c.email})")),
)
)
Loading