Skip to content

[18.0] [FIX] mass_mailing_custom_unsubscribe: Allow redirect to mailing list manager on unsubscribe#9

Merged
OCA-git-bot merged 2 commits into
OCA:18.0from
moduon:18.0-allow_redirect_to_maling_list_manager-mass_mailing_custom_unsubscribe
Apr 15, 2026
Merged

[18.0] [FIX] mass_mailing_custom_unsubscribe: Allow redirect to mailing list manager on unsubscribe#9
OCA-git-bot merged 2 commits into
OCA:18.0from
moduon:18.0-allow_redirect_to_maling_list_manager-mass_mailing_custom_unsubscribe

Conversation

@Shide
Copy link
Copy Markdown
Contributor

@Shide Shide commented Nov 7, 2025

When unsubscribing from a list, you cannot select a reason until you go to the mailing list manager. Now, you can choose with a system parameter to redirect directly to the mailing list manager and give the user in the first place an option to select a reason to opt out.

https://www.loom.com/share/7801fec1afb24e1bb51c74b0c1fdbe1d

MT-12505 @moduon @yajo @EmilioPascual @chienandalu @rafaelbn please review if you want 😄

@rafaelbn rafaelbn added this to the 18.0 milestone Nov 7, 2025
Comment thread mass_mailing_custom_unsubscribe/controllers/main.py Outdated
Comment thread mass_mailing_custom_unsubscribe/controllers/main.py Outdated
@Shide Shide force-pushed the 18.0-allow_redirect_to_maling_list_manager-mass_mailing_custom_unsubscribe branch 4 times, most recently from b6c8f24 to 03e0185 Compare November 10, 2025 11:50
@Shide Shide requested review from chienandalu and yajo November 10, 2025 11:52
Copy link
Copy Markdown
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review 👍

Comment thread mass_mailing_custom_unsubscribe/controllers/main.py
Comment thread mass_mailing_custom_unsubscribe/controllers/main.py Outdated
Comment thread mass_mailing_custom_unsubscribe/readme/CONFIGURE.md Outdated
@sergiocorato
Copy link
Copy Markdown

@Shide Do you plan to follow @yajo comments?

@Shide Shide force-pushed the 18.0-allow_redirect_to_maling_list_manager-mass_mailing_custom_unsubscribe branch from 03e0185 to 997028d Compare April 8, 2026 08:29
@Shide
Copy link
Copy Markdown
Contributor Author

Shide commented Apr 8, 2026

@yajo @chienandalu @sergiocorato all suggestions attended

@Shide Shide requested review from chienandalu and yajo April 8, 2026 08:31
@Shide Shide force-pushed the 18.0-allow_redirect_to_maling_list_manager-mass_mailing_custom_unsubscribe branch from 997028d to 4776f3b Compare April 8, 2026 08:33
Copy link
Copy Markdown
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-9-by-yajo-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 13, 2026
Signed-off-by yajo
@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Copy Markdown
Contributor

@yajo your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-9-by-yajo-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yajo
Copy link
Copy Markdown
Member

yajo commented Apr 13, 2026

Could you rebase please?

… manager on unsubscribe

When unsubscribing from a list, you cannot select a reason until you go to the mailing list manager.
Now, you can choose with a system parameter to redirect directly to the mailing list manager and give the user in the first place an option to select a reason to opt out.
@Shide Shide force-pushed the 18.0-allow_redirect_to_maling_list_manager-mass_mailing_custom_unsubscribe branch from 4776f3b to 9268f00 Compare April 15, 2026 07:32
@OCA-git-bot OCA-git-bot added mod:mass_mailing_custom_unsubscribe Module mass_mailing_custom_unsubscribe series:18.0 labels Apr 15, 2026
@Shide Shide force-pushed the 18.0-allow_redirect_to_maling_list_manager-mass_mailing_custom_unsubscribe branch from aa99748 to e3cdb0c Compare April 15, 2026 07:58
Comment thread mass_mailing_custom_unsubscribe/tests/test_ui.py Outdated
@Shide Shide force-pushed the 18.0-allow_redirect_to_maling_list_manager-mass_mailing_custom_unsubscribe branch from e3cdb0c to ff9d510 Compare April 15, 2026 08:05
@Shide
Copy link
Copy Markdown
Contributor Author

Shide commented Apr 15, 2026

There's an ongoing fix to deal with this new issue from the repo template itself: OCA/oca-addons-repo-template#344

@yajo Added the same commit than other repos that need to be rid of the chrome zombie process log

Copy link
Copy Markdown
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to update from template, but this shouldn't break that, so merging.

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-9-by-yajo-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e20e5f0 into OCA:18.0 Apr 15, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 9768b74. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 18.0-allow_redirect_to_maling_list_manager-mass_mailing_custom_unsubscribe branch April 20, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants