[IMP]-mis_builder-enhance-multi-company-support #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @sbidoul, |
Summary of Changes Made 1. KPI Matrix Enhancement (kpimatrix.py) Problem Solved: The original code assumed accounts always had a single company_id field Solution: Enhanced _get_account_name() method to handle both: Single company accounts (company_id field) Multi-company accounts (company_ids field) Key Improvements: Safe field checking with hasattr() Smart display limiting to 3 companies max Graceful fallback when company info is missing 2. Accounting Expression Parser Enhancement (aep.py) Problem Solved: Runtime errors when processing accounting data from companies not pre-loaded in company_rates Solution: Added dynamic company rate calculation Key Improvements: On-demand rate calculation for missing companies Proper currency conversion handling Unit Tests add env mock constructors pre commit test fix test fix remove validate remove unhashable type list
geraldo29
force-pushed
the
IMP]-mis_builder-enhance-multi-company-support
branch
from
cc638a6 to
537c065
Compare
|
LGTM! |
BhaveshHeliconia
approved these changes
Jul 28, 2025
|
Hello @OCA/mis-builder-maintainers is this possible to merge, already checked and working fine. |
Member
|
Hello, could you do separate PRs for the two topics, which seem independent? This is will facilitate review. Also, please don't mix bug fixes and improvements, that will also make things quicker to review. |
|
The KPI Matrix Enhancement (kpimatrix.py) fix works |
Member
|
@geraldo29 Thanks for the fixes! Because you seem to be too busy to follow-up, I've split up the account company_id issue to #730 as the reviewer requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes Made
KPI Matrix Enhancement (kpimatrix.py) Problem Solved: The original code assumed accounts always had a single company_id field Solution: Enhanced _get_account_name() method to handle both: Single company accounts (company_id field)
Multi-company accounts (company_ids field)
Key Improvements:
Safe field checking with hasattr()
Smart display limiting to 3 companies max
Graceful fallback when company info is missing
Accounting Expression Parser Enhancement (aep.py) Problem Solved: Runtime errors when processing accounting data from companies not pre-loaded in company_rates Solution: Added dynamic company rate calculation
Key Improvements:
On-demand rate calculation for missing companies
Proper currency conversion handling
Description
Did not create issue
Test
added unit tests