[FIX] partner_address_street3: copy street3 from parent when creating contact

[fsmw]

Summary

When creating a contact inside a company using the "Add" button in Contacts & Addresses, the street3 field was not being copied from the parent company, unlike other address fields (street, street2, zip, city, etc.).

Fix

Override default_get to copy all address fields (including street3) from the parent company when creating a child contact.

Steps to reproduce

1. Create a company contact and set a value in the Street 3 field
2. Click Add in Contacts & Addresses to create a contact in the company
3. The Create Contact dialog shows an empty Street 3 field

Expected behavior

The Street 3 value should be copied from the parent company.

Fixes

Closes #2298

[Copilot]

Pull request overview

This PR addresses a UI defaulting gap in partner_address_street3: when creating a child contact from a company via Contacts & Addresses, the street3 value wasn’t prefilled from the parent company.

Changes:

• Add a default_get override on res.partner to copy address fields (including street3) from the parent when parent_id is set.
• Reuse _address_fields() as the source of fields to copy.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

default_get currently overwrites any default values already provided by super().default_get()/context for the address fields (e.g., default_street, default_city, etc.). This can change existing behavior outside the “create contact under company” flow. Consider only filling fields that are missing/empty (e.g., via setdefault or a if not values.get(field) guard) so explicit defaults aren’t clobbered.

Suggested change

	if field in default_fields and field in parent._fields:
	if (
	field in default_fields
	and field in parent._fields
	and not values.get(field)
	):

[Copilot]

There’s test coverage for street3 syncing on create()/write(), but this PR changes the default_get behavior (the regression reported in the UI happens before record creation). Please add/adjust a test that asserts default_get (or a Form created with default_parent_id in context) pre-fills street3 from the parent company.

[Copilot]

field in parent._fields is redundant here because parent is a res.partner record and _address_fields() returns partner field names; removing this extra check would simplify the loop (and avoids hiding problems if _address_fields() ever returns an invalid entry).

Suggested change

	if field in default_fields and field in parent._fields:
	if field in default_fields:

[luisDIXMIT]

The street3 field still doesn’t seem to be copied.

[BhaveshHeliconia]

• We can use this code snippet to avoid context overwrite in XML:
  @api.onchange("parent_id")
  def onchange_parent_id(self):
  result = super().onchange_parent_id() or {}
  if self.parent_id:
  result.setdefault("value", {})["street3"] = self.parent_id.street3
  return result

• Also, there would be no need of default_get after this.

• This works for v17+.

[fsmw]

Removed the redundant field in parent._fields check — _address_fields() returns res.partner field names so the guard is always True. Good catch @NL66278 and @BhaveshHeliconia.

[BhaveshHeliconia]

It’s still not working in this case. Did you check my suggestion?
Steps to Reproduce:

• Open Contact form
• Set street3 field
• Click on 'Add' button under Contacts & Addresses without saving parent contact
• Now, observe that street3 is not being set in child contact form.

[fsmw]

Update: switched from onchange to default_get (mirrors the 19.0 fix in #2352)

@BhaveshHeliconia @NL66278 @luisDIXMIT

You were right — the @api.onchange("parent_id") override from commit f524e12 does not fire in the inline "Add in Contacts & Addresses" form, because that flow passes default_parent_id in the context and never triggers a user-driven onchange. I was able to reproduce the issue described in BhaveshHeliconia's review of 2026-05-21 ("It's still not working in this case") on the unsaved-parent path.

New approach (commit 9c2df1fb): override default_get instead. It reads default_parent_id from the context (falling back to values.get("parent_id")) and copies all _address_fields() (including street3) from the parent, with a if not values.get(field) guard so explicit defaults still win.

This is the same approach we just landed in the 19.0 sister PR #2352 (commit 16282c0), where it was reviewed and CI-validated. Both branches now share the same shape, which should make backports easier.

Tests updated:

• test_default_get_copies_street3_from_default_parent_id — replicates the inline form context (default_parent_id in context).
• test_default_get_does_not_overwrite_explicit_value — explicit defaults win.
• test_default_get_no_parent — no parent, no copy.

Pre-commit passes locally. Could you re-review when you have a moment? 🙏