Skip to content

[19.0][MIG] partner_address_format_domestic: Migration to 19.0#2345

Open
AungKoKoLin1997 wants to merge 7 commits into
OCA:19.0from
qrtl:19.0-mig-partner_address_format_domestic
Open

[19.0][MIG] partner_address_format_domestic: Migration to 19.0#2345
AungKoKoLin1997 wants to merge 7 commits into
OCA:19.0from
qrtl:19.0-mig-partner_address_format_domestic

Conversation

@AungKoKoLin1997
Copy link
Copy Markdown
Contributor

@qrtl QT6658

@OCA-git-bot OCA-git-bot added series:19.0 mod:partner_address_format_domestic Module partner_address_format_domestic labels May 14, 2026
Copy link
Copy Markdown

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and tested locally because runboat is broken, LGTM justo one minor question

Comment thread partner_address_format_domestic/models/res_country.py Outdated
Copy link
Copy Markdown

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread partner_address_format_domestic/tests/test_partner_address_format_domestic.py Outdated
Comment thread partner_address_format_domestic/models/res_country.py
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 19.0-mig-partner_address_format_domestic branch from 156436a to 690b636 Compare May 18, 2026 02:10
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as draft May 19, 2026 01:16
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review May 19, 2026 01:19
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

Copy link
Copy Markdown
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LTGM.

Comment thread partner_address_format_domestic/models/res_country.py Outdated
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 19.0-mig-partner_address_format_domestic branch from 690b636 to e47ee07 Compare May 28, 2026 07:19
Copy link
Copy Markdown

@nobuQuartile nobuQuartile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Code review and functional review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants