[19.0][FIX] partner_contact_address_default: invalidate parent cache on archive#2349
Open
fsmw wants to merge 1 commit into
Open
[19.0][FIX] partner_contact_address_default: invalidate parent cache on archive#2349fsmw wants to merge 1 commit into
fsmw wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:19.0
mod:partner_contact_address_default
BhaveshHeliconia
approved these changes
May 19, 2026
…ng child contact When a child contact is archived, the parent partner's delivery/invoice/ contact default fields are cleared. Without explicit cache invalidation, stale values could be returned by address_get in multi-module contexts (e.g. auditlog). Changes: - Split parents search and cache invalidation into explicit steps - Call invalidate_recordset on aggregated parent set for all three fields - Add test_contact_address_archived_cache ensuring no stale id after archive Fixes OCA#2347
fsmw
force-pushed
the
19.0-fix-partner-contact-address-default-stale-cache
branch
from
16fa9da to
aa3581c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2347
When a child contact is archived, the parent partner fields partner_delivery_id, partner_invoice_id and partner_contact_id are cleared. Without explicit cache invalidation, stale values can persist in multi-module contexts and be returned by address_get.
Changes:
Run pre-commit locally: passed.