Skip to content

[19.0][MIG] partner_contact_tags_in_popup: Migration to 19.0#2355

Open
dnplkndll wants to merge 10 commits into
OCA:19.0from
ledoent:19.0-mig-partner_contact_tags_in_popup
Open

[19.0][MIG] partner_contact_tags_in_popup: Migration to 19.0#2355
dnplkndll wants to merge 10 commits into
OCA:19.0from
ledoent:19.0-mig-partner_contact_tags_in_popup

Conversation

@dnplkndll
Copy link
Copy Markdown

@dnplkndll dnplkndll commented May 20, 2026

Port of partner_contact_tags_in_popup from 18.0 to 19.0. Follows the OCA migration guide.

Non-mechanical adaptation worth flagging:

  • Odoo 19's res.partner form renamed the mobile field to phone. The popup-tags view inheritance had to switch from //field[@name='mobile'] to //field[@name='phone'] to keep its anchor.

@OCA-git-bot OCA-git-bot added series:19.0 mod:partner_contact_tags_in_popup Module partner_contact_tags_in_popup labels May 20, 2026
@dnplkndll dnplkndll force-pushed the 19.0-mig-partner_contact_tags_in_popup branch from 0cf91d0 to f1db4af Compare May 20, 2026 17:12
@dnplkndll dnplkndll marked this pull request as draft May 20, 2026 17:19
@dnplkndll dnplkndll force-pushed the 19.0-mig-partner_contact_tags_in_popup branch from f1db4af to 9b91c08 Compare May 20, 2026 18:23
@dnplkndll dnplkndll marked this pull request as ready for review May 20, 2026 18:34
@dnplkndll dnplkndll force-pushed the 19.0-mig-partner_contact_tags_in_popup branch 2 times, most recently from 68dddca to 9a93fd2 Compare May 20, 2026 19:21
@dnplkndll
Copy link
Copy Markdown
Author

ready to review @carmenbianca @benbrich

@dnplkndll dnplkndll force-pushed the 19.0-mig-partner_contact_tags_in_popup branch 2 times, most recently from c6e6ccf to 68dddca Compare May 29, 2026 20:09
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some view touchups here

Image

- Bump version 18.0.x.y.z → 19.0.1.0.0 in __manifest__.py
- Pre-commit auto-format fixes
- README.rst regenerated from readme/ fragments

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
@dnplkndll dnplkndll force-pushed the 19.0-mig-partner_contact_tags_in_popup branch from 68dddca to e0b2571 Compare June 2, 2026 19:26
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:partner_contact_tags_in_popup Module partner_contact_tags_in_popup series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants