[19.0][FIX] base_rest_pydantic: remove duplicate installable key#614
[19.0][FIX] base_rest_pydantic: remove duplicate installable key#614fsmw wants to merge 1 commit into
Conversation
|
@fsmw thank you for the fix. Can you let the version untouched so I can merge your fix. In practice, the version should never be modified by hand. The merge process will take car of it if appropriate. |
| "summary": """ | ||
| Pydantic binding for base_rest""", | ||
| "version": "18.0.1.0.2", | ||
| "version": "18.0.1.0.3", |
There was a problem hiding this comment.
| "version": "18.0.1.0.3", | |
| "version": "18.0.1.0.2", |
- Remove installable nested inside external_dependencies dict - Ensure manifest conforms to standard Odoo schema - Fixes OCA#612
e0c7ad5 to
31bb962
Compare
|
Hi @lmignon, thanks for the review! I've removed the version bump as requested. The version stays at |
CI failure is pre-existingThe CI failure ( Evidence: the 18.0 branch has the exact same CI failure (run 26630008184): All 24 fastapi tests pass (0 failed, 0 errors). The only "error" is this deprecation warning from the This PR only touches This appears to be a known issue that will need a separate fix in the |
Issue: #612
Problem:
The
__manifest__.pycontained a duplicateinstallablekey. One instance was incorrectly nested inside theexternal_dependenciesdict, making the manifest invalid according to the standard Odoo schema.Fix:
installablekey fromexternal_dependenciesinstallablekey to the root dict with proper double quotesBefore:
After:
Fixes #612