Skip to content

[19.0][FIX] base_rest_pydantic: remove duplicate installable key#614

Open
fsmw wants to merge 1 commit into
OCA:19.0from
fsmw:19.0-fix-base_rest_pydantic-manifest-612
Open

[19.0][FIX] base_rest_pydantic: remove duplicate installable key#614
fsmw wants to merge 1 commit into
OCA:19.0from
fsmw:19.0-fix-base_rest_pydantic-manifest-612

Conversation

@fsmw
Copy link
Copy Markdown

@fsmw fsmw commented May 17, 2026

Issue: #612

Problem:
The __manifest__.py contained a duplicate installable key. One instance was incorrectly nested inside the external_dependencies dict, making the manifest invalid according to the standard Odoo schema.

Fix:

  • Removed the nested installable key from external_dependencies
  • Moved the remaining installable key to the root dict with proper double quotes
  • Bumped version from 18.0.1.0.2 to 18.0.1.0.3

Before:

"external_dependencies": {
    "python": [
        "pydantic>=2.0.0",
    ],
    "installable": False,
},
    "installable": False,
}

After:

"external_dependencies": {
    "python": [
        "pydantic>=2.0.0",
    ],
},
"installable": False,
}

Fixes #612

@OCA-git-bot OCA-git-bot added series:19.0 mod:base_rest_pydantic Module base_rest_pydantic labels May 17, 2026
@lmignon
Copy link
Copy Markdown
Contributor

lmignon commented May 27, 2026

@fsmw thank you for the fix. Can you let the version untouched so I can merge your fix. In practice, the version should never be modified by hand. The merge process will take car of it if appropriate.

Comment thread base_rest_pydantic/__manifest__.py Outdated
"summary": """
Pydantic binding for base_rest""",
"version": "18.0.1.0.2",
"version": "18.0.1.0.3",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "18.0.1.0.3",
"version": "18.0.1.0.2",

- Remove installable nested inside external_dependencies dict
- Ensure manifest conforms to standard Odoo schema
- Fixes OCA#612
@fsmw fsmw force-pushed the 19.0-fix-base_rest_pydantic-manifest-612 branch from e0c7ad5 to 31bb962 Compare May 29, 2026 17:27
@fsmw
Copy link
Copy Markdown
Author

fsmw commented May 29, 2026

Hi @lmignon, thanks for the review! I've removed the version bump as requested. The version stays at 18.0.1.0.2 and the PR now only contains the fix for the duplicate installable key. Ready for re-review.

@fsmw
Copy link
Copy Markdown
Author

fsmw commented May 29, 2026

CI failure is pre-existing

The CI failure (test with Odoo and test with OCB) is caused by oca_checklog_odoo flagging a StarletteDeprecationWarning from fastapi/testclient.py as an error — this is unrelated to the manifest fix in this PR.

Evidence: the 18.0 branch has the exact same CI failure (run 26630008184):

StarletteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead.

All 24 fastapi tests pass (0 failed, 0 errors). The only "error" is this deprecation warning from the starlette dependency, which oca_checklog_odoo treats as a failure.

This PR only touches base_rest_pydantic/__manifest__.py (removes duplicate installable key, fixes quotes) — the module has installable: False so it is not even installed during testing.

This appears to be a known issue that will need a separate fix in the fastapi addon (updating the starlette/httpx dependency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:base_rest_pydantic Module base_rest_pydantic series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants