Skip to content

[12.0][FIX] sale_triple_discount: Computed discount might exceed discount's precision#1618

Closed
SimoRubi wants to merge 1 commit into
OCA:12.0from
SimoRubi:12.0-fix-sale_triple_discount-round_discount
Closed

[12.0][FIX] sale_triple_discount: Computed discount might exceed discount's precision#1618
SimoRubi wants to merge 1 commit into
OCA:12.0from
SimoRubi:12.0-fix-sale_triple_discount-round_discount

Conversation

@SimoRubi
Copy link
Copy Markdown
Member

Steps to reproduce

  1. Create a sale order
  2. Add a line having:
    • price_unit = 420
    • discount = 45
    • discount2 = 10
    • discount3 = 5
  3. Save the sale order

Actual behavior
Subtotal for the line is 197.48

Expected behavior
Subtotal for the line is 197.51

@SimoRubi SimoRubi force-pushed the 12.0-fix-sale_triple_discount-round_discount branch from 630646a to 9ca331f Compare June 17, 2021 13:16
@SimoRubi
Copy link
Copy Markdown
Member Author

@OCA/crm-sales-marketing-maintainers can this be merged or do I have to fix anything?
Thanks!

@tafaRU
Copy link
Copy Markdown
Member

tafaRU commented Sep 1, 2021

@SimoRubi could you please have a look at SimoRubi#1 ?

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 25, 2023
@github-actions github-actions Bot closed this Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement needs review stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants