Skip to content

[18.0][IMP] sale_order_line_sequence: show line number in portal#4344

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
cetmix:18.0-t5426-sale_order_line_sequence-fix_bug_with_portal
Jun 8, 2026
Merged

[18.0][IMP] sale_order_line_sequence: show line number in portal#4344
OCA-git-bot merged 1 commit into
OCA:18.0from
cetmix:18.0-t5426-sale_order_line_sequence-fix_bug_with_portal

Conversation

@tendil
Copy link
Copy Markdown
Contributor

@tendil tendil commented May 18, 2026

Display the sale order line visible sequence in the portal sales order preview, so the portal view is aligned with the backend form and the sale order PDF report.

Task: 5426

@OCA-git-bot OCA-git-bot added series:18.0 mod:sale_order_line_sequence Module sale_order_line_sequence labels May 18, 2026
ivs-cetmix
ivs-cetmix approved these changes Jun 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

Aldeigja
Aldeigja approved these changes Jun 8, 2026
View reviewed changes
Copy link
Copy Markdown

@Aldeigja Aldeigja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LGTM

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 8, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ivs-cetmix
Copy link
Copy Markdown
Member

ivs-cetmix commented Jun 8, 2026

Hey @OCA/crm-sales-marketing-maintainers , let's merge this tiny yet very useful PR 🤗

@tafaRU
Copy link
Copy Markdown
Member

tafaRU commented Jun 8, 2026

@tendil thanks for the PR!
Only one note: wouldn't it be better to add the template to views/sale_portal_templates.xml just like it's done in the original? (ref: https://github.com/odoo/odoo/blob/7a6518e39d34575a3977e7c4a0053a45223e203c/addons/sale/views/sale_portal_templates.xml#L385)

@tendil
[IMP] sale_order_line_sequence: show line number in portal
d7beb1c 
Display the sale order line visible sequence in the portal sales order
preview, so the portal view is aligned with the backend form and the
sale order PDF report.

Task: 5426
@tendil tendil force-pushed the 18.0-t5426-sale_order_line_sequence-fix_bug_with_portal branch from bbfb86a to d7beb1c Compare June 8, 2026 16:16
@tendil
Copy link
Copy Markdown
Contributor Author

tendil commented Jun 8, 2026

@tendil thanks for the PR! Only one note: wouldn't it be better to add the template to views/sale_portal_templates.xml just like it's done in the original? (ref: https://github.com/odoo/odoo/blob/7a6518e39d34575a3977e7c4a0053a45223e203c/addons/sale/views/sale_portal_templates.xml#L385)

good point, thanks!
moved the portal template inheritance to views/sale_portal_templates.xml

@tafaRU
Copy link
Copy Markdown
Member

tafaRU commented Jun 8, 2026

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 8, 2026

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-4344-by-tafaRU-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3b88552 into OCA:18.0 Jun 8, 2026
9 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 8, 2026

Congratulations, your PR was merged at b1801f8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivs-cetmix ivs-cetmix ivs-cetmix approved these changes

@tafaRU tafaRU tafaRU approved these changes

+1 more reviewer

@Aldeigja Aldeigja Aldeigja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved enhancement merged 🎉 mod:sale_order_line_sequence Module sale_order_line_sequence ready to merge series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tendil @OCA-git-bot @ivs-cetmix @tafaRU @Aldeigja @rousseldenis