Skip to content

[18.0][ADD] sale_order_warehouse_header#4360

Open
IriaAlonso wants to merge 1 commit into
OCA:18.0from
solvosci:18.0-add-sale_order_warehouse_header
Open

[18.0][ADD] sale_order_warehouse_header#4360
IriaAlonso wants to merge 1 commit into
OCA:18.0from
solvosci:18.0-add-sale_order_warehouse_header

Conversation

@IriaAlonso
Copy link
Copy Markdown
Contributor

@IriaAlonso IriaAlonso commented May 25, 2026

Moves warehouse field in sales orders form to header, so it becomes more accessible. Improvements in the search view:

  • Filter by warehouse.
  • Group by warehouse.

@OCA-git-bot OCA-git-bot added series:18.0 mod:sale_order_warehouse_header Module sale_order_warehouse_header labels May 25, 2026
@IriaAlonso IriaAlonso force-pushed the 18.0-add-sale_order_warehouse_header branch from b0c1303 to 10cdf1f Compare May 26, 2026 07:49
cgarcia-solvos
cgarcia-solvos reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cgarcia-solvos cgarcia-solvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review. LGTM!
Only minor comment:

cgarcia-solvos
cgarcia-solvos reviewed May 26, 2026
View reviewed changes
Comment thread sale_order_warehouse_header/views/sale_order_views.xml Outdated
Comment on lines +13 to +14
<record id="sale_order_view_form" model="ir.ui.view">
<field name="name">sale.order</field>
Copy link
Copy Markdown
Contributor

@cgarcia-solvos cgarcia-solvos May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename id and name from the views to make them clearer:

Suggested change
<record id="sale_order_view_form" model="ir.ui.view">
<field name="name">sale.order</field>
<record id="sale_order_view_form_inherit_warehouse_header" model="ir.ui.view">
<field name="name">sale.order.form (in sale_order_warehouse_header)</field>

Copy link
Copy Markdown
Contributor Author

@IriaAlonso IriaAlonso Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@IriaAlonso IriaAlonso force-pushed the 18.0-add-sale_order_warehouse_header branch from 10cdf1f to 61c7d3c Compare June 3, 2026 08:31
@IriaAlonso
Copy link
Copy Markdown
Contributor Author

IriaAlonso commented Jun 3, 2026

@rousseldenis can you review it please?

rousseldenis
rousseldenis reviewed Jun 4, 2026
View reviewed changes
Comment thread sale_order_warehouse_header/views/sale_order_views.xml Outdated
<field name="model">sale.order</field>
<field name="inherit_id" ref="sale_stock.view_order_form_inherit_sale_stock" />
<field name="arch" type="xml">
<xpath expr="//field[@name='warehouse_id'][2]" position="attributes">
Copy link
Copy Markdown
Contributor

@rousseldenis rousseldenis Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you have a better anchor than [2] ?

@IriaAlonso
[ADD] sale_order_warehouse_header
078ce3c 
Moves warehouse field in sales orders form to header, so it becomes more accessible.
Improvements in the search view:
- Filter by warehouse.
- Group by warehouse.
@IriaAlonso IriaAlonso force-pushed the 18.0-add-sale_order_warehouse_header branch from 61c7d3c to 078ce3c Compare June 5, 2026 09:02
@IriaAlonso
Copy link
Copy Markdown
Contributor Author

IriaAlonso commented Jun 5, 2026

@rousseldenis done

@rousseldenis
Copy link
Copy Markdown
Contributor

rousseldenis commented Jun 8, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 8, 2026

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-4360-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 8, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 8, 2026

@rousseldenis The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_sale_order_warehouse_header-18.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_sale_order_warehouse_header-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

+1 more reviewer

@cgarcia-solvos cgarcia-solvos cgarcia-solvos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:sale_order_warehouse_header Module sale_order_warehouse_header ready to merge series:18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IriaAlonso @rousseldenis @OCA-git-bot @cgarcia-solvos