[18.0][IMP] sale_elaboration: use state instead of parent.state#4363
Open
CarlosRoca13 wants to merge 1 commit into
Open
[18.0][IMP] sale_elaboration: use state instead of parent.state#4363CarlosRoca13 wants to merge 1 commit into
CarlosRoca13 wants to merge 1 commit into
Conversation
`parent.state` is only available when a view is rendered embedded inside a One2many (e.g. the order_line subform). When `sale.order.line` is opened as a standalone form (sale_order_line_view_form_readonly), there is no parent context, causing Owl to raise: EvalError: Name 'parent' is not defined `sale.order.line` already exposes `state = fields.Selection(related='order_id.state')`, so replacing `parent.state` with `state` is semantically equivalent and works in both embedded and standalone contexts.
Contributor
|
Hi @yajo, @rafaelbn, @sergio-teruel, |
sergio-teruel
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parent.stateis only available when a view is rendered embedded inside a One2many (e.g. the order_line subform). Whensale.order.lineis opened as a standalone form (sale_order_line_view_form_readonly), there is no parent context, causing Owl to raise:EvalError: Name 'parent' is not defined
sale.order.linealready exposesstate = fields.Selection(related='order_id.state'), so replacingparent.statewithstateis semantically equivalent and works in both embedded and standalone contexts.cc @Tecnativa TT62707
ping @sergio-teruel @carlosdauden