[18.0][ADD] sale_pricelist_multi_discount#4365
Draft
LorenzoC0 wants to merge 1 commit into
Draft
Conversation
Adds a distribution-like field in the pricelist formula discount field
OCA-git-bot
added
series:18.0
mod:sale_pricelist_multi_discount
eLBati
suggested changes
Jun 3, 2026
| Distribution widget in the *Percentage* and *Formula* compute modes. | ||
| When the rule has a non-empty distribution, the rule's `_compute_price` | ||
| applies all discounts multiplicatively and the sale order line copies | ||
| the same list into its own `discount_distribution` field.<> No newline at end of file |
| "by this pricelist rule.", | ||
| ) | ||
|
|
||
| def _compute_price(self, product, quantity, uom, date, currency=None): |
Member
There was a problem hiding this comment.
instead of overriding _compute_price, is it possible to store the aggregated percentage into the native percent_price / price_discount whenever discount_distribution changes (compute/inverse). Then core's _compute_price works unmodified and the override disappears entirely.
Also, README should be changed about percent_price
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on OCA/account-invoicing#2364 and #4364
This module adds a distribution-like field in the pricelist discount field, enabling infinite multiplicative discounts.
This module likely conflicts with some other modules that modify the behavior of the discount field in pricelists. I could use some help figuring out which of these modules are incompatible, so I can add them as exclusions in the manifest. Thanks!