[19.0][IMP] sale_order_mass_action: adds missing target states#4371
Open
glitchov wants to merge 23 commits into
Open
[19.0][IMP] sale_order_mass_action: adds missing target states#4371glitchov wants to merge 23 commits into
glitchov wants to merge 23 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:sale_order_mass_action
FrancoMaxime
approved these changes
Jun 2, 2026
Member
FrancoMaxime
left a comment
FrancoMaxime
left a comment
There was a problem hiding this comment.
LGTM: code review (a minor comment in unit test)
| # Check if the sale order is locked | ||
| self.assertFalse(self.sale.locked) | ||
| self.wizard = self.wizard_obj.with_context( | ||
| active_model="sale.order", active_ids=[self.sale.id] |
Member
There was a problem hiding this comment.
Suggested change
| active_model="sale.order", active_ids=[self.sale.id] | |
| active_model="sale.order", active_ids=self.sale.ids |
Is it not better to do that?
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_mass_action Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_mass_action/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_mass_action Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_mass_action/
[MIG] sale_order_mass_action: Migration to 18.0 [MIG] sale_order_mass_action: Migration to 18.0
glitchov
force-pushed
the
19.0-imp-sale_order_mass_action-hda
branch
from
e8745a8 to
d89ca58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original module only permits to confirm in mass so this enhancement targets other states plus the locked flag.
The original idea comes from @rousseldenis in v14.0