[19.0][MIG] sale_order_restrict_copy_archived_product: Migration to 19.0#4375
Open
apik-mgu wants to merge 10 commits into
Open
[19.0][MIG] sale_order_restrict_copy_archived_product: Migration to 19.0#4375apik-mgu wants to merge 10 commits into
apik-mgu wants to merge 10 commits into
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_restrict_copy_archived_product Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_restrict_copy_archived_product/es/
OCA-git-bot
added
series:19.0
mod:sale_order_restrict_copy_archived_product
BhaveshHeliconia
suggested changes
Jun 1, 2026
Contributor
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Consider using BaseCommon instead of TransactionCase. In this case, there’s no need to redefine cls.env with tracking_disable=True, and res.partner is already available via BaseCommon. This would help simplify and optimize the test code.
| from odoo.tests.common import TransactionCase | ||
|
|
||
|
|
||
| class TestSaleOrderRestrictCopyArchivedProduct(TransactionCase): |
Contributor
There was a problem hiding this comment.
Suggested change
| class TestSaleOrderRestrictCopyArchivedProduct(TransactionCase): | |
| class TestSaleOrderRestrictCopyArchivedProduct(Basecommon): |
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.partner = cls.env["res.partner"].create({"name": "Test Partner"}) |
Contributor
There was a problem hiding this comment.
Suggested change
| cls.partner = cls.env["res.partner"].create({"name": "Test Partner"}) |
Comment on lines
+26
to
+28
| ( | ||
| 0, | ||
| 0, |
Contributor
There was a problem hiding this comment.
Suggested change
| ( | |
| 0, | |
| 0, | |
| Command.create( |
Comment on lines
+45
to
+47
| ( | ||
| 0, | ||
| 0, |
Contributor
There was a problem hiding this comment.
Suggested change
| ( | |
| 0, | |
| 0, | |
| Command.create( |
apik-mgu
force-pushed
the
19.0-mig-sale_order_restrict_copy_archived_product
branch
2 times, most recently
from
83ed03b to
74ae281
Compare
apik-mgu
force-pushed
the
19.0-mig-sale_order_restrict_copy_archived_product
branch
from
74ae281 to
fd59daf
Compare
Author
|
@BhaveshHeliconia Requested changes completed Good day! |
Contributor
|
@apik-mgu could you please check the failing test/ci? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.