[18.0][IMP] sale_planner_calendar: allow sales managers to edit non-private events#4390
Open
CarlosRoca13 wants to merge 1 commit into
Open
[18.0][IMP] sale_planner_calendar: allow sales managers to edit non-private events#4390CarlosRoca13 wants to merge 1 commit into
CarlosRoca13 wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:18.0
mod:sale_planner_calendar
… events Override _compute_user_can_edit so users in the group_sale_manager group can edit any event that is not marked as private, in addition to the default editability rules.
CarlosRoca13
force-pushed
the
18.0-IMP-sale_planner_calendar
branch
from
196bb31 to
a47dc4a
Compare
carlosdauden
approved these changes
Jun 8, 2026
| if ( | ||
| self.env.context.get("force_user_can_edit_event") | ||
| and self.env.user.has_group("sales_team.group_sale_manager") | ||
| and event.target_partner_id |
Contributor
There was a problem hiding this comment.
Set this as first condition.
We must order from high to low performance conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override _compute_user_can_edit so users in the group_sale_manager group can edit any event that is not marked as private, in addition to the default editability rules.
cc @Tecnativa TT62811
ping @carlosdauden @sergio-teruel