-
-
Notifications
You must be signed in to change notification settings - Fork 181
[19.0][MIG] portal_debranding: migrate #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19.0][MIG] portal_debranding: migrate #109
Conversation
|
/ocabot migration portal_odoo_debranding |
|
Thanks, @pedrobaeza - I’ll definitely take care of that and remove the “Powered by Odoo” footer. If you notice any other Odoo-related branding that should be stripped out, please let me know and I’ll handle those too. I think this module should cover a bit more ground - I can already think of the website onboarding page and the “Powered by Odoo” strings at the bottom of the initial settings screen. What do you think? Also, I’ve noticed that Odoo alert modals sometimes include “Odoo” in their titles. I’ve seen some third-party modules handle that kind of debranding as well - do you think that’s something we could leverage here?
|
|
There's already a module for the website: https://github.com/OCA/website/tree/18.0/website_odoo_debranding It should be maybe hosted here, but it's for now on OCA/website, and the idea is to not make this current module to depend on other modules that may or may not be installed. |
|
I’ll try to migrate that module to version 19 as well so we can have a complete rebranding suite. By the way, what about the Odoo branding shown at the bottom of the Settings page under Developer Tools? Should we handle that here too, or would you prefer it to stay out of scope? |
|
Well, the idea of this module is to prevent an outsider to see the brand Odoo. If you have access to the settings, you probably know that you are using Odoo, hehe. |
|
Got it 🙂 I’ll try to make the module cover as much of the debranding as possible while keeping things clean. Once it’s done, we can review together and decide which parts make sense to keep or remove. |
|
Hi @pedrobaeza!
If you spot any other remaining Odoo branding, happy to include it as well. |
|
Thanks for the changes. Another good change is to rename the module to |
|
Thanks for the renaming. For having the whole commit history renamed, as if not, the commit history will be lost on next version, please do: |
fb9bae3 to
2d031ee
Compare
|
Hi @pedrobaeza , I rewrote the entire branch history to preserve ancestry using:
Force-pushed the branch; PR #109 is updated. I also adjusted the title to “Portal” and renamed the tests accordingly. For anyone with the branch checked out:
|
|
BTW, it’s been great aligning and merging all the debranding modules into a coherent suite. Really appreciate your guidance throughout! @pedrobaeza |
pedrobaeza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work! You may want to add yourself in CONTRIBUTORS.md
|
@tishmen @pedrobaeza : something else that might be included in the portal debranding code. Not sure how long this already exists in Odoo honestly, but it is full of "Odoo" references. With the E-Invoicing modules being more frequently used, this modal can be opened in the /my/purchase and /my/orders screen. Dependency on edi_ubl modules before the button starts showing. See below screenshot and source code of the modal.
(sale/views/sale_portal_templates.xml) |
|
@bjornbillen that requires an extra glue module For now, let's merge this one. /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
[UPD] Update portal_odoo_debranding.pot [UPD] README.rst [UPD] README.rst
- Migrate and rename to V-Name `portal_debranding` - Align test imports and rename tests to test_portal_debranding - Regenerate README/static description
96e4c74 to
f0410aa
Compare
|
This PR has the |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 3d14d53. Thanks a lot for contributing to OCA. ❤️ |




Scope
Depends on
Summary
portal_debrandingto remove redundant wording.Pre-commit
Tests
./odoo/odoo-bin -c odoo.conf -d <db> -i portal_debranding --test-enable --stop-after-initReview notes