[19.0][IMP] base_tier_validation_formula: code widget on python expressions#28
Open
bosd wants to merge 1 commit into
Open
[19.0][IMP] base_tier_validation_formula: code widget on python expressions#28bosd wants to merge 1 commit into
bosd wants to merge 1 commit into
Conversation
- Apply widget="code" with python mode to reviewer_expression so the Python Expression reviewer field gets syntax-highlighted editing, matching the treatment of python_code. - Move python_code into its own full-width (col="4"/colspan="4") group so the code editor is no longer squeezed to half-width inside the default 2-column "Apply On" group. - Add placeholder hints listing the available locals on both fields.
OCA-git-bot
added
mod:base_tier_validation_formula
santostelmo
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
widget="code"withoptions="{'mode': 'python'}"toreviewer_expression, so the Python Expression reviewer field gets the same syntax-highlighted editor aspython_code.python_codeinto its own full-width group (col="4"/colspan="4") so the code editor is no longer squeezed to half-width inside the default 2-column Apply On group.placeholderhints on both fields listing the available locals (rec, expected return type) for the first time a user clears the default.Test plan
tier.definitionrecord, set Review Type = Python Expression: the Review Expression field renders with the code widget (syntax highlighting, monospace) and takes full sheet width.Before:
After:
