Skip to content

[19.0][FIX] base_tier_validation: comment support approve_sequence_bypass#37

Open
bosd wants to merge 1 commit into
OCA:19.0from
bosd:19.0-fix-base_tier_validation-comment-bypass-and-notes
Open

[19.0][FIX] base_tier_validation: comment support approve_sequence_bypass#37
bosd wants to merge 1 commit into
OCA:19.0from
bosd:19.0-fix-base_tier_validation-comment-bypass-and-notes

Conversation

@bosd
Copy link
Copy Markdown
Contributor

@bosd bosd commented May 14, 2026

Summary

Forward-port of the first commit (ff56b14f) from OCA/server-ux#1156 (authored by @mathbenTechnolibre / ERPLibre) onto 19.0.

When a reviewer's tier was auto-bypassed by approve_sequence_bypass, the comment they entered in the wizard was attached to the wrong review (or repeated across reviews). Now the comment is attached only to the last review in the bypass chain, eliminating repetition.

Why only one of the two upstream commits

The upstream PR also bundled a second, unrelated commit (d3d98d52 — "add note accepted/refused if missing email") that changed notification behaviour by always posting a chatter note when notifications couldn't be sent. Cherry-picking that one broke three pre-existing tests on v19 (test_19_waiting_tier, test_19a_notify_on_pending_sequence_negative, test_20_no_sequence) — they assert exact message_ids counts and expect specific notification bodies, and the extra chatter posts violated those expectations. Dropped that commit; it can be revisited as its own PR once the test expectations are reconciled.

Credit

Original commit: ff56b14f by @mathbenTechnolibre. Cherry-picked unchanged onto 19.0; merge auto-resolved cleanly.

Test plan

Two-tier definition with approve_sequence_bypass=True; reviewer who covers tiers 1 and 2 approves with a comment via the wizard. The comment should appear once on the last review, not twice.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:base_tier_validation Module base_tier_validation series:19.0 labels May 14, 2026
@bosd bosd marked this pull request as draft May 14, 2026 10:00
@bosd bosd force-pushed the 19.0-fix-base_tier_validation-comment-bypass-and-notes branch from 563c957 to c8f94e4 Compare May 14, 2026 10:01
@bosd bosd changed the title [19.0][FIX] base_tier_validation: comment bypass + chatter notes when no email [19.0][FIX] base_tier_validation: comment support approve_sequence_bypass May 14, 2026
- the comment will only be added to last review and remove repetition
@bosd bosd force-pushed the 19.0-fix-base_tier_validation-comment-bypass-and-notes branch from c8f94e4 to e52eabc Compare May 14, 2026 10:03
@bosd bosd marked this pull request as ready for review May 14, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:base_tier_validation Module base_tier_validation series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants