[19.0][FIX] base_tier_validation: comment support approve_sequence_bypass#37
Open
bosd wants to merge 1 commit into
Open
[19.0][FIX] base_tier_validation: comment support approve_sequence_bypass#37bosd wants to merge 1 commit into
bosd wants to merge 1 commit into
Conversation
Contributor
|
Hi @LoisRForgeFlow, |
563c957 to
c8f94e4
Compare
- the comment will only be added to last review and remove repetition
c8f94e4 to
e52eabc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-port of the first commit (
ff56b14f) from OCA/server-ux#1156 (authored by @mathbenTechnolibre / ERPLibre) onto 19.0.When a reviewer's tier was auto-bypassed by
approve_sequence_bypass, the comment they entered in the wizard was attached to the wrong review (or repeated across reviews). Now the comment is attached only to the last review in the bypass chain, eliminating repetition.Why only one of the two upstream commits
The upstream PR also bundled a second, unrelated commit (
d3d98d52— "add note accepted/refused if missing email") that changed notification behaviour by always posting a chatter note when notifications couldn't be sent. Cherry-picking that one broke three pre-existing tests on v19 (test_19_waiting_tier,test_19a_notify_on_pending_sequence_negative,test_20_no_sequence) — they assert exactmessage_idscounts and expect specific notification bodies, and the extra chatter posts violated those expectations. Dropped that commit; it can be revisited as its own PR once the test expectations are reconciled.Credit
Original commit:
ff56b14fby @mathbenTechnolibre. Cherry-picked unchanged onto 19.0; merge auto-resolved cleanly.Test plan
Two-tier definition with
approve_sequence_bypass=True; reviewer who covers tiers 1 and 2 approves with a comment via the wizard. The comment should appear once on the last review, not twice.