[19.0][FIX] base_tier_validation_forward: forward notification delivery#38
Open
bosd wants to merge 1 commit into
Open
[19.0][FIX] base_tier_validation_forward: forward notification delivery#38bosd wants to merge 1 commit into
bosd wants to merge 1 commit into
Conversation
OCA-git-bot
added
mod:base_tier_validation_forward
Contributor
|
Hi @kittiu, |
Two bugs prevent forwarded review notifications from reaching the target user: 1. _get_forwarded_notification_subtype() returns the wrong xmlid "base_tier_validation.mt_tier_validation_forwarded" but the mail.message.subtype record is defined in base_tier_validation_forward. message_post() silently falls back to mail.mt_note (internal note) which does not generate email notifications for followers. 2. The forward wizard add_forward() creates a tier.review for the target user but never calls message_subscribe(). Without being a follower of the record, the target user cannot receive any email notifications — even if the subtype were correct. Combined effect: when a reviewer forwards their approval to another user, the target user is never notified and the forward appears to "not work" from the end-user perspective. Fixes: - Correct the module prefix in _get_forwarded_notification_subtype() - Call message_subscribe() in add_forward() to subscribe the forward target as a follower with the forward notification subtype
bosd
force-pushed
the
19.0-fix-base_tier_validation_forward-notification-delivery
branch
from
0b8152e to
57f9ac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-port of OCA/server-ux#1279 (authored by @lala-labiso / Labiso GmbH) onto 19.0.
When a reviewer used the Forward wizard to hand off their review, the chatter notification on the validated document wasn't actually being delivered to the newly-assigned reviewer. The forward wizard updated the tier review's reviewer but didn't trigger a
message_notify/ activity for the new assignee, so the receiving party only found out about the assignment by stumbling on the systray counter (or never).This PR makes the wizard explicitly notify the new reviewer(s) after the forward, with an appropriate chatter entry and (where applicable) a scheduled activity.
Credit
Original commit:
82b2d01eby @lala-labiso. Cherry-picked unchanged onto 19.0; merge auto-resolved cleanly.Test plan
Upstream PR's regression test is included (
test_tier_validation.pyadditions). Manually: assign a tier review to user A, forward it to user B via the wizard, observe that user B receives the chatter / activity notification.