Skip to content

[17.0][ADD] sale_certification#42

Open
christian-ramos-tecnativa wants to merge 1 commit into
OCA:17.0from
BinhexTeam:17.0-add-sale_certification
Open

[17.0][ADD] sale_certification#42
christian-ramos-tecnativa wants to merge 1 commit into
OCA:17.0from
BinhexTeam:17.0-add-sale_certification

Conversation

@christian-ramos-tecnativa
Copy link
Copy Markdown

@christian-ramos-tecnativa christian-ramos-tecnativa commented Jun 16, 2025

Module to handle the certification step in a contruction company
ROADMAP:

  • Handle retentions
  • Create Tests
  • Improve README

@christian-ramos-tecnativa christian-ramos-tecnativa force-pushed the 17.0-add-sale_certification branch 2 times, most recently from d1fdfb2 to 69a2d89 Compare July 21, 2025 12:10
@christian-ramos-tecnativa christian-ramos-tecnativa changed the title [WIP][ADD] sale_certification [17.0][ADD] sale_certification Jul 21, 2025
@christian-ramos-tecnativa christian-ramos-tecnativa marked this pull request as ready for review July 21, 2025 12:17
@christian-ramos-tecnativa christian-ramos-tecnativa force-pushed the 17.0-add-sale_certification branch 2 times, most recently from 11f3e38 to eccf6a3 Compare August 4, 2025 11:31
Copy link
Copy Markdown

@edescalona edescalona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yoana-RB
Copy link
Copy Markdown

Hello, could you please enable the Runboat? Thank you!

@christian-ramos-tecnativa
Copy link
Copy Markdown
Author

Hi @edescalona can you rebase the branch and push it? Thanks!

@edescalona edescalona force-pushed the 17.0-add-sale_certification branch from eccf6a3 to 0d02cb3 Compare May 21, 2026 14:38
@OCA-git-bot OCA-git-bot added mod:sale_certification Module sale_certification series:17.0 labels May 21, 2026
@edescalona
Copy link
Copy Markdown

Hi @Yoana-RB @christian-ramos-tecnativa , runboat is now enabled.

Copy link
Copy Markdown

@Yoana-RB Yoana-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the functionality is correct and the implementation is solid. The functional review is approved (LGTM). However, I have identified a few improvement points and pending aspects that would be worth reviewing, although these are non-blocking comments:

Translations: They do not appear to be implemented yet and should be added to ensure a consistent user experience across all supported languages.

UI improvements: The current certificate view could benefit from a clearer visual hierarchy. Adding a more representative title or header would improve readability and make it easier to identify the displayed information.
‎sale_certification/views/view_order_form_certify.xml

Grouped certifications: When certifying multiple orders, it may be worth considering support for grouped certificate management, either by allowing invoicing from a group of certificates or by grouping multiple orders within a single certificate. This would simplify scenarios where a consolidated invoice is generated from multiple orders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:sale_certification Module sale_certification series:17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants