-
Notifications
You must be signed in to change notification settings - Fork 0
CIS-3896 Upgrade to Spring Boot 4 and Java 21 #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,10 +75,10 @@ private Mustache.Formatter mustacheFormatter() { | |
| return new Mustache.Formatter() { | ||
|
|
||
| public String format(Object value) { | ||
| if (value instanceof LocalDate) { | ||
| return dateFormatter.print((LocalDate) value); | ||
| } else if (value instanceof LocalDateTime) { | ||
| return dateTimeFormatter.print((LocalDateTime) value); | ||
| if (value instanceof LocalDate date) { | ||
| return dateFormatter.print(date); | ||
| } else if (value instanceof LocalDateTime time) { | ||
| return dateTimeFormatter.print(time); | ||
|
Comment on lines
+78
to
+81
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is new syntax as of Java 16 that allows using the value checked by |
||
| } else { | ||
| return String.valueOf(value); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 7 additions & 7 deletions
14
src/test/java/org/octri/common/validation/CurrentOrFutureDateValidatorTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,34 @@ | ||
| package org.octri.common.validation; | ||
|
|
||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| import java.time.LocalDate; | ||
|
|
||
| import org.junit.Test; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class CurrentOrFutureDateValidatorTest { | ||
|
|
||
| private CurrentOrFutureDateValidator validator = new CurrentOrFutureDateValidator(); | ||
|
|
||
| @Test | ||
| public void testCurrentDateIsValid() { | ||
| assertTrue("Current LocalDate should be valid", validator.isValid(LocalDate.now(), null)); | ||
| assertTrue(validator.isValid(LocalDate.now(), null), "Current LocalDate should be valid"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testFutureDateIsValid() { | ||
| assertTrue("Future LocalDate should be valid", validator.isValid(LocalDate.now().plusDays(1), null)); | ||
| assertTrue(validator.isValid(LocalDate.now().plusDays(1), null), "Future LocalDate should be valid"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testNullIsValid() { | ||
| assertTrue("Null LocalDate should be valid", validator.isValid(null, null)); | ||
| assertTrue(validator.isValid(null, null), "Null LocalDate should be valid"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testPastDateIsNotValid() { | ||
| assertFalse("Past date should not be valid", validator.isValid(LocalDate.now().minusDays(1), null)); | ||
| assertFalse(validator.isValid(LocalDate.now().minusDays(1), null), "Past date should not be valid"); | ||
| } | ||
|
|
||
| } |
14 changes: 7 additions & 7 deletions
14
src/test/java/org/octri/common/validation/CurrentOrPastDateValidatorTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,34 @@ | ||
| package org.octri.common.validation; | ||
|
|
||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| import java.time.LocalDate; | ||
|
|
||
| import org.junit.Test; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class CurrentOrPastDateValidatorTest { | ||
|
|
||
| private CurrentOrPastDateValidator validator = new CurrentOrPastDateValidator(); | ||
|
|
||
| @Test | ||
| public void testCurrentDateIsValid() { | ||
| assertTrue("Current LocalDate should be valid", validator.isValid(LocalDate.now(), null)); | ||
| assertTrue(validator.isValid(LocalDate.now(), null), "Current LocalDate should be valid"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testPastDateIsValid() { | ||
| assertTrue("Future LocalDate should be valid", validator.isValid(LocalDate.now().minusDays(1), null)); | ||
| assertTrue(validator.isValid(LocalDate.now().minusDays(1), null), "Future LocalDate should be valid"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testNullIsValid() { | ||
| assertTrue("Null LocalDate should be valid", validator.isValid(null, null)); | ||
| assertTrue(validator.isValid(null, null), "Null LocalDate should be valid"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testFutureDateIsNotValid() { | ||
| assertFalse("Past date should not be valid", validator.isValid(LocalDate.now().plusDays(1), null)); | ||
| assertFalse(validator.isValid(LocalDate.now().plusDays(1), null), "Past date should not be valid"); | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the updated artifact IDs here (
spring-boot-starter-webmvcandwebjars-locator-lite) something you had to do manually, or was that handled by OpenRewrite?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was handled by OpenRewrite. Spring Boot's packages were made more granular, and the OpenRewrite recipe knows what transformations to make.