-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Include less v3 #7618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include less v3 #7618
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7618 +/- ##
==========================================
- Coverage 75.73% 75.72% -0.01%
==========================================
Files 659 659
Lines 185740 185740
==========================================
- Hits 140669 140657 -12
- Misses 45071 45083 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
7d7b5c9 to
c53e0fc
Compare
|
Information: QA ran without warnings. Pipeline 8149 |
|
Information: QA ran without warnings. Pipeline 8150 |
c53e0fc to
dc7f061
Compare
|
Replaced by #7643 |
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/945
Describe changes:
Still to do : add
cppcleanas part of CI, so that means having a reproducible cleaner scriptI used this patched version myint/cppclean#165
There are still exceptions :
TAILQwith including queue.h (or red and black tree)#define a(x) b(x)where b is in another file cfSpmSearchThe result is less includes from header file to another, nothing is done for C files including a useless header
Modifies #7570 with rebase and dummy commit to check if it passes CI
This PR adds about one hundred lines
#include "detect-engine-build.h"because it is being used in util tests forSigGroupBuildand such... Any thoughts on that ?