Skip to content

feat: restore the cluster deployment layer under clusters/sandbox#65

Merged
rpignolet merged 4 commits into
OKDP:mainfrom
jpmewenemesse:feat/restore-deployment-layer
Jul 10, 2026
Merged

feat: restore the cluster deployment layer under clusters/sandbox#65
rpignolet merged 4 commits into
OKDP:mainfrom
jpmewenemesse:feat/restore-deployment-layer

Conversation

@jpmewenemesse

@jpmewenemesse jpmewenemesse commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

  • Restore the OKDP cluster deployment layer under clusters/sandbox/
  • Contexts are restored with the improved naming introduced in platform-packages
  • Reference packages at the new unversioned OCI path
  • Fixed bug related to triggers list (synchronize instead of synchronized)
  • Brought back deployment validation workflow from platform-packages without the packages build and publish related stuffs
  • Brought back ci deployment validation workflow from platform-packages without packages build and publish related stuffs

Related Issue

Fixes #64

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor / chore
  • Breaking change

How to Test

  • Do a complete okdp sandbox deployment under the new files and folder structure
  • No deployment failed by issuing kubectl get po -A or kubectl get release -A should show READY for all of the releases

Checklist

  • I have tested my changes
  • Documentation updated if needed
  • If breaking change: migration path described above
  • I hereby declare this contribution to be licensed under the Apache License Version 2.0.
  • I hereby agree to grant TOSIT a copyright license to use my contributions.

The contexts improved namings files are kept

reference packages at the new unversioned OCI path
@jpmewenemesse jpmewenemesse self-assigned this Jul 8, 2026
@jpmewenemesse jpmewenemesse added the enhancement New feature or request label Jul 8, 2026
corrected small bug on conventional commit pr trigger

make sure to specify flux v2.7.5 because kuboCD does not support latest CRD
@jpmewenemesse
jpmewenemesse requested a review from a team July 8, 2026 13:25
Add a Kind + FLux + KuboCD workflow that applies clusters/sandbox/{contexts,releases}/

keep package build publish stuffs in platform-packages
@jpmewenemesse
jpmewenemesse force-pushed the feat/restore-deployment-layer branch from 09de75b to 160b964 Compare July 8, 2026 13:34
@jpmewenemesse
jpmewenemesse requested review from a team July 8, 2026 14:40
idirze
idirze previously requested changes Jul 10, 2026

@idirze idirze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Approving functionally.
Note: The commit history does not include the original commits (authors).

@jpmewenemesse

Copy link
Copy Markdown
Contributor Author

Hello,

Approving functionally. Note: The commit history does not include the original commits (authors).

I did not moved the commits from other work. I just copied the files themselves as the file structure is different

@mdrutel mdrutel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on a fresh cluster :

  • Installation of a cluster
  • Test of service installation
    Everything is OK

@idirze
idirze dismissed their stale review July 10, 2026 09:22

Functionally OK. Provenance can be discussed with other reviewers.

Comment on lines +31 to +34
endpoints:
apiUrl: https://seaweedfs-{{ .Release.namespace }}.{{ .Context.ingress.suffix }}
stsUrl: https://seaweedfs-{{ .Release.namespace }}.{{ .Context.ingress.suffix }}
consoleUrl: https://seaweedfs-console-{{ .Release.namespace }}.{{ .Context.ingress.suffix }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make this endpoint backend-neutral as well.

Since the sandbox currently exposes a single default object storage, consumers don't need to know whether it's backed by SeaweedFS, RustFS or another S3-compatible implementation.

Using a stable hostname such as s3. (and s3-console.) keeps the public endpoint aligned with the storage contract and avoids leaking the backend implementation into the sandbox configuration.

This also makes future backend switches transparent without changing the external URLs.

Suggested change
endpoints:
apiUrl: https://seaweedfs-{{ .Release.namespace }}.{{ .Context.ingress.suffix }}
stsUrl: https://seaweedfs-{{ .Release.namespace }}.{{ .Context.ingress.suffix }}
consoleUrl: https://seaweedfs-console-{{ .Release.namespace }}.{{ .Context.ingress.suffix }}
endpoints:
apiUrl: https://s3.{{ .Context.ingress.suffix }}
stsUrl: https://s3.{{ .Context.ingress.suffix }}
consoleUrl: https://s3-console.{{ .Context.ingress.suffix }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open a new PR for this subject.

@rpignolet
rpignolet merged commit 9b804ea into OKDP:main Jul 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore the cluster deployment layer (releases, contexts, flux) under clusters/sandbox

6 participants