feat: restore the cluster deployment layer under clusters/sandbox#65
Conversation
The contexts improved namings files are kept reference packages at the new unversioned OCI path
corrected small bug on conventional commit pr trigger make sure to specify flux v2.7.5 because kuboCD does not support latest CRD
Add a Kind + FLux + KuboCD workflow that applies clusters/sandbox/{contexts,releases}/
keep package build publish stuffs in platform-packages
09de75b to
160b964
Compare
idirze
left a comment
There was a problem hiding this comment.
Hello,
Approving functionally.
Note: The commit history does not include the original commits (authors).
I did not moved the commits from other work. I just copied the files themselves as the file structure is different |
mdrutel
left a comment
There was a problem hiding this comment.
I tested on a fresh cluster :
- Installation of a cluster
- Test of service installation
Everything is OK
Functionally OK. Provenance can be discussed with other reviewers.
| endpoints: | ||
| apiUrl: https://seaweedfs-{{ .Release.namespace }}.{{ .Context.ingress.suffix }} | ||
| stsUrl: https://seaweedfs-{{ .Release.namespace }}.{{ .Context.ingress.suffix }} | ||
| consoleUrl: https://seaweedfs-console-{{ .Release.namespace }}.{{ .Context.ingress.suffix }} |
There was a problem hiding this comment.
I think we can make this endpoint backend-neutral as well.
Since the sandbox currently exposes a single default object storage, consumers don't need to know whether it's backed by SeaweedFS, RustFS or another S3-compatible implementation.
Using a stable hostname such as s3. (and s3-console.) keeps the public endpoint aligned with the storage contract and avoids leaking the backend implementation into the sandbox configuration.
This also makes future backend switches transparent without changing the external URLs.
| endpoints: | |
| apiUrl: https://seaweedfs-{{ .Release.namespace }}.{{ .Context.ingress.suffix }} | |
| stsUrl: https://seaweedfs-{{ .Release.namespace }}.{{ .Context.ingress.suffix }} | |
| consoleUrl: https://seaweedfs-console-{{ .Release.namespace }}.{{ .Context.ingress.suffix }} | |
| endpoints: | |
| apiUrl: https://s3.{{ .Context.ingress.suffix }} | |
| stsUrl: https://s3.{{ .Context.ingress.suffix }} | |
| consoleUrl: https://s3-console.{{ .Context.ingress.suffix }} |
There was a problem hiding this comment.
Please open a new PR for this subject.
Description
clusters/sandbox/platform-packagessynchronizeinstead ofsynchronized)platform-packageswithout the packages build and publish related stuffsplatform-packageswithout packages build and publish related stuffsRelated Issue
Fixes #64
Type of Change
How to Test
kubectl get po -Aorkubectl get release -Ashould showREADYfor all of the releasesChecklist