Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b34539672c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
athena-omt
left a comment
There was a problem hiding this comment.
Thanks — this is a strong step toward a real fleet reconciler, but I’m requesting changes for two blockers:
-
In
src/fleet.ts,reconcileOneRepo()callsapplyGitHub(manifest)when--apply-githubis set without--apply-repo, but still returnsstatus: "planned". The CLI summary also only talks about repo drift/status. So a mutating run can still read like a plan for that repo, which is too misleading for an operation that changes labels/settings. -
The
--apply-repo --create-pr --apply-githubpath does not handle “GitHub drift only” repos correctly. IfrepoDrift === falsebutapplyGitHub === true, the code can still enterapplyRepoThroughPullRequest(), which always doesgit commit -m .... On a repo with nothing to commit, that fails instead of applying GitHub drift and skipping PR creation.
Once those are fixed, I’d be happy to take another look. I reviewed the diff in the provided worktree and attempted lightweight local validation, but the worktree did not have the dev toolchain installed to run the TypeScript/Vitest gate directly.
Stale after follow-up commit d28ab2d fixed the fleet reconciliation blockers; checks are green.
athena-omt
left a comment
There was a problem hiding this comment.
APPROVE — re-reviewed after d28ab2d. The prior blockers are resolved: reconciliation no longer creates GitHub-only worktrees before validating local repo presence, and branch push handling no longer silently claims success after failed pushes. Current checks are green.
Summary
Governing Issue
No governing issue is linked; this is bootstrap control-plane follow-up requested directly in this thread.
Validation
Bootstrap Governance
Merge Automation
Notes