Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: defa3acf5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| repoDisablesAutoMerge(manifest, repo) || | ||
| organizationPlanDisablesPrivateRepoAutoMerge(manifest, owner, organization) |
There was a problem hiding this comment.
Base fallback planning on desired repo visibility
planGitHub currently triggers the auto-merge-plan-limited action whenever the existing repo is private and reports allow_auto_merge: false, even if this run is about to change visibility to public. In that scenario (for example, moving a private repo to public on GitHub Free), auto-merge can be available after apply, so the plan incorrectly tells operators to use manual fallback merge readiness and can produce plan/apply mismatch.
Useful? React with 👍 / 👎.
athena-omt
left a comment
There was a problem hiding this comment.
I reviewed the current diff against issue #12. I do not have an additional independent blocker beyond the existing unresolved inline comment on src/github/provision.ts: the fallback planning signal is still based on the current repo visibility/allow_auto_merge state, so a private-to-public visibility change can incorrectly report the manual fallback path even though auto-merge should become available after apply. That should be resolved before treating this as merge-ready.
Validation note: I was not able to run local read-only checks because shell commands failed before execution in this environment with bwrap: Failed to make / slave: Permission denied; this review is based on the GitHub connector diff, issue context, and changed file contents.
Summary
Governing Issue
Closes #12
Validation
npm run checkCI GateBootstrap Governance
CONTRIBUTING.md,.github/PULL_REQUEST_TEMPLATE.md, anddocs/bootstrap/onboarding.mdwhen applicableMerge Automation
Notes