Skip to content

Harden Lume runner lifecycle scripts#88

Merged
jmcte merged 4 commits intomainfrom
codex/lume-hardening-help
Apr 26, 2026
Merged

Harden Lume runner lifecycle scripts#88
jmcte merged 4 commits intomainfrom
codex/lume-hardening-help

Conversation

@jmcte
Copy link
Copy Markdown
Contributor

@jmcte jmcte commented Apr 25, 2026

Summary

  • add operator-facing --help usage to Lume lifecycle scripts
  • detach slot and worker processes with setsid-backed spawn helper
  • propagate guest PATH and tolerate already-removed ephemeral runner registrations

Verification

  • pnpm test -- test/lume-scripts.test.ts test/lume-config.test.ts test/lume-project.test.ts
  • pnpm lint

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 06436c80e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/lume/lib.sh
@jmcte jmcte enabled auto-merge (squash) April 25, 2026 16:49
@jmcte jmcte requested a review from pheidon April 25, 2026 20:23
Copy link
Copy Markdown
Contributor

@pheidon pheidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pheidon pass: reviewed diff and green checks look good. Approving.

@jmcte jmcte merged commit 9c55934 into main Apr 26, 2026
9 of 10 checks passed
@jmcte jmcte deleted the codex/lume-hardening-help branch April 26, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants