fix(frame): treat a bare @reverse term as reference-valued - #4
Merged
Merged
Conversation
A reverse term's values are node references by definition, so "@type": "@id" beside it is redundant and authors omit it. Keying only on @type missed the idiomatic spelling, and framing embedded the targets. Refs OO-LD/oold-schema#181
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
referencePropertieskeyed on"@type": "@id"alone, so a term mapped with@reversewas only recognised when the author also wrote the coercion - which JSON-LD 1.1 §4.1.10 makes redundant, since a reverse term's values are node references by definition.Without the subframe, framing embeds the reverse targets: the defect OO-LD/oold-schema#160 closed, reachable again through the idiomatic spelling. Every existing fixture passed because the specification's worked example writes both.
Spec change: OO-LD/oold-schema#181, which adds
@reverseas a fourth signal toOOLD-EXT-6d10. Port: OO-LD/oold-python#164.npm test: 6 passing.