ci: pin the specification checkout to a tag - #5
Merged
Merged
Conversation
The README states this package pins a specification tag; the workflow checked out the default branch, so a green run meant agreement with whatever had landed there rather than with a named release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.mdsays this package "pins a specification tag, runs the conformance suite, and keeps passing it". The workflow checked outOO-LD/oold-schemawith noref:, so it tracked the default branch and a green run meant agreement with whatever had landed there, not with a named release.Pinned to
v1.0.0-rc.5, the release this package currently conforms to. Bump deliberately when adopting a new one.Benign until now only by accident:
mainhappened to be newer than the validatoroold-schemaitself pinned, so this repository was validating against a later specification state than the other implementation.