fix: a schema with no @context loses nothing - #6
Merged
Merged
Conversation
An absent context maps nothing, so every declared property is unmapped and none can be lost. Reporting them failed a schema for the one thing OOLD-SCH-2d05 says must not fail it, and doubled up on a finding the meta-schema already makes. Closes #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1, the documented divergence from
oold-python, which fixed the same thing in OO-LD/oold-python#141.An absent
@contextmaps nothing, so every declared property is unmapped and none can be lost: there was never a term to lose it through. Reporting them fails a schema for the one thingOOLD-SCH-2d05says must not fail it.rc.4 does not make this moot. The schema is now rejected by the meta-schema, but the round-trip check still ran and added a second, spurious finding on top of the real one, so the two implementations still disagreed on invalid input.
Measured on the issue's own repro plus a control:
The false positive goes, the true positive stays.
npm test: 6 passing.