fix(rules): stamp since with the release a rule ships in - #182
Merged
Merged
Conversation
extract_rules.py stamped a new rule with the most recent tag, which names the previous release. Every entry in the catalogue was one release early: the 66 rules claiming rc.1 first shipped in rc.2, the 7 claiming rc.2 shipped in rc.3, and the 15 claiming rc.3 have not shipped at all. A new rule now records 'unreleased' and promote_since.py resolves it when a release is tagged, because the number is not knowable while authoring. Also bumps the validator pin from 0.18.1, which has no reference_properties and emits no @embed @Never, so CI gated the release with a validator that predates the rule it was checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from a review of
v1.0.0-rc.3..main. Both matter before rc.4 is tagged; the first is irreversible once it is.Every
sincewas one release earlyextract_rules.pystamped a newly minted rule withgit describe- the most recent tag. That names the previous release, not the one being cut, so a rule authored between rc.3 and rc.4 was recorded as having shipped in rc.3.Checked against the tagged catalogues themselves:
1.0.0-rc.11.0.0-rc.21.0.0-rc.3recorded_since()then carries each value forward forever, so tagging rc.4 would have frozen the 15 permanently.A new rule now records
since: unreleased, andscripts/promote_since.pyresolves it at tag time:It touches only
unreleasedentries; every other value records a release that has shipped. The existing data is shifted one release forward to what the tags prove.spec_version()stays, but only for the catalogue header, where "the release this tree descends from" is what is meant.The pinned validator predated its own rules
OOLD_VERSIONwas0.18.1, whoseoold.validation.framehas noreference_propertiesand never emits@embed: @never:.github/workflows/main.ymlrunsmake validate, so CI gated rc.4 with a validator older thanOOLD-EXT-68fa, the MUST this range strengthened. Bumped to1.0.1;make validatepasses identically (380 ok, 76 ok, 0 failed).Note 1.0.1 still predates the
@reversesignal (OO-LD/oold-python#164, merged but unreleased), so the pin wants bumping again once that ships.Also
docs/contributing.mdgains a release section covering both: howunreleasedis resolved, and when to bump the pin.Verified:
make checkend to end - 380 ok and 76 ok 0 failed, spec and baseline checks pass, site builds, and the promotion script round-trips.