docs: close three gaps the 1.0.0 review left open - #195
Merged
Merged
Conversation
- contributing said nothing is pushed to main while the release recipe three sections below commits there - the legacy-OSW migration named x-oold-reverse-default-properties as a migration target; it was withdrawn in rc.4 - governance gave a tie-break to a specification lead, a role MAINTAINERS.md does not name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-blocking findings from the pre-tag review, now that 1.0.0 is out.
docs/contributing.mdstates "Nothing is pushed tomaindirectly" three sections above a release recipe that commits onmainand tags it. The tag has to point at that commit, so the recipe is right and the rule needed the exception.docs/migration/from-legacy-osw.mdpresentsx-oold-reverse-default-propertiesas something a legacy schema migrates to. It was withdrawn from the vocabulary in 1.0.0-rc.4. Since nothing rejects it, a reader following that page produces a schema that validates and silently does nothing.GOVERNANCE.mdresolves maintainer disagreement through "the specification lead". No such role exists inMAINTAINERS.md, which assigns areas instead. Now points at the area.One finding from the review is deliberately left:
OOLD-EXT-9ee8opens on "Such a tool" with no antecedent in its own sentence. Its text is hashed and shipped in 1.0.0, so rewording it is a catalogue change rather than a typo fix, and it reads correctly in the rendered specification where the preceding sentence is adjacent.