Make AggregateActionxData More Amenable to Unit Testing

[bska]

This PR revises the set of AggregateActionxData constructors to take simpler types. Previously, we needed a full Schedule object in order to form instances of AggregateActionxData and constructing Schedule objects, at least those that are viable for Actionx restart file unit testing, is very hard to do without parsing a mostly complete input file. This, in turn, made unit testing the class harder than necessary.

The new canonical constructor takes the actual ActionX objects as a std::span<> and derives object and line counts from those. We still need a UnitSystem, well names, and start/elapsed times, but we now pass those through a new, dedicated "context" object instead of getting the values from a Schedule object.

We also create two free function overloads to simplify transition to the new constructor, but expect that those will be removed in due time. For now though, they're used in the existing unit test for class AggregateActionxData.

[bska]

I'm creating this PR in draft mode because it depends on, and contains, the earlier PR #5238. I will keep the PR in a draft state until such time as it is ready for review.

[Copilot]

Pull request overview

This PR refactors Opm::RestartIO::Helpers::AggregateActionxData construction to remove the hard dependency on a fully-populated Schedule, making the type easier to instantiate in isolation for unit tests and other callers.

Changes:

• Introduces a new “canonical” AggregateActionxData constructor that takes std::span<const Action::ActionX> plus a dedicated AggregateActionxRuntimeContext.
• Adds createAggregateActionxData(...) overloads to adapt existing call sites (notably Schedule-based usage) to the new constructor.
• Updates restart-writing code and unit tests to use the new factory function and adds a new span-based constructor test.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tests/test_AggregateActionxData.cpp	Adds a new standalone span-based constructor test and migrates existing tests to the factory helper.
opm/output/eclipse/RestartIO.cpp	Switches restart output generation to use createAggregateActionxData(...).
opm/output/eclipse/AggregateActionxData.hpp	Adds runtime context struct, span-based constructor, deprecated compatibility ctor, and factory function declarations.
opm/output/eclipse/AggregateActionxData.cpp	Implements span-based construction path and the new factory function overloads.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.