Use Fira Mono or monospace for code, not sans#615
Open
wenzeslaus wants to merge 1 commit intoOSGeo:masterfrom
Open
Use Fira Mono or monospace for code, not sans#615wenzeslaus wants to merge 1 commit intoOSGeo:masterfrom
wenzeslaus wants to merge 1 commit intoOSGeo:masterfrom
Conversation
Fira Sans Mono is not a font name as far as I can tell. The font name is Fira Mono. Fallback for code should be monospace, not sans-serif, so using that. We don't ship it or link Fira Mono at this point, but I'm fixing the CSS now as a hot fix and leaving the font addition for later. I'm setting explicit font for pre so that if pre appears without code and Fira Mono is available, we get consistent font with code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fira Sans Mono is not a font name as far as I can tell. The font name is Fira Mono.
Fallback for code should be monospace, not sans-serif, so using that.
We don't ship it or link Fira Mono at this point, but I'm fixing the CSS now as a hot fix and leaving the font addition for later.
I'm setting explicit font for pre so that if pre appears without code and Fira Mono is available, we get consistent font with code.