wxGUI/locdownload: show progress of downloading new location as Data Catalog info bar message

[tmszi]

Implementing/close feature #3278.

wxgui_locdownload_dialog_as_bg.mp4

[landam]

Works nicely, thanks for improvement. @tmszi Some notes below:

• would be nice to avoid blinking Abort button when progress is updated (minor issue)
• when download process is finished Abort button does nothing - it should be automatically removed (major issue)

[tmszi]

Works nicely, thanks for improvement. @tmszi Some notes below:

* would be nice to avoid blinking `Abort` button when progress is updated (minor issue)

* when download process is finished `Abort` button does nothing - it should be automatically removed (major issue)

Thank for review and suggestions. Both issues are fixed with commit no. cfb83a5.

[landam]

Thank for review and suggestions. Both issues are fixed with commit no.

Great, I tested updated PR and I can confirm that both issues are fixed.

[landam]

@tmszi Small note: It make sense to me to show the dialog for selecting location to be downloaded when process of downloading is aborted. I am just not sure whether it make sense to show the dialog on successful download.

[landam]

When testing multiple times I am getting error:

Traceback (most recent call last):
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/gui/wxpython/core/gthread.py", line 138, in OnDone

event.ondone(event)
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/gui/wxpython/startup/locdownload.py", line 411, in
download_complete_callback

self.parent.newLocationIsDownloaded.emit()
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/etc/python/grass/pydispatch/signal.py", line 233, in
emit

dispatcher.send(signal=self, *args, **kwargs)
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/etc/python/grass/pydispatch/dispatcher.py", line 343, in
send

response = robustapply.robustApply(
^
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/etc/python/grass/pydispatch/robustapply.py", line 60, in
robustApply

return receiver(*arguments, **named)
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/gui/wxpython/datacatalog/tree.py", line 1652, in
AddDownloadedNewLocation

self._reloadGrassDBNode(self.selected_grassdb[0])

[tmszi]

@tmszi Small note: It make sense to me to show the dialog for selecting location to be downloaded when process of downloading is aborted. I am just not sure whether it make sense to show the dialog on successful download.

Fixed with 90e4a7c.

[tmszi]

When testing multiple times I am getting error:

Traceback (most recent call last):
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/gui/wxpython/core/gthread.py", line 138, in OnDone

event.ondone(event)
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/gui/wxpython/startup/locdownload.py", line 411, in
download_complete_callback

self.parent.newLocationIsDownloaded.emit()
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/etc/python/grass/pydispatch/signal.py", line 233, in
emit

dispatcher.send(signal=self, *args, **kwargs)
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/etc/python/grass/pydispatch/dispatcher.py", line 343, in
send

response = robustapply.robustApply(
^
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/etc/python/grass/pydispatch/robustapply.py", line 60, in
robustApply

return receiver(*arguments, **named)
  File "/home/martin/src/grass/dist.x86_64-pc-linux-
gnu/gui/wxpython/datacatalog/tree.py", line 1652, in
AddDownloadedNewLocation

self._reloadGrassDBNode(self.selected_grassdb[0])

I wasn't successfull to reproduce it.

[landam]

I wasn't successfull to reproduce it.

I tested again with the same result:

@tmszi It seems to be related to multiple GRASS data dirs (databases). I tried to removed second data dir and download was successful then

[landam]

I was not able to reproduce this bug in the main branch. So it seems to be related to this PR.

[tmszi]

I was not able to reproduce this bug in the main branch. So it seems to be related to this PR.

I can' reproduce it (I tried with 2 and 3 GRASS GIS database directories added). Could you send me exact follow steps to reproduce it, please?

Tested with Python/wxPython version:

GRASS fire_grass6data/demomapset:~ > python3 -c "import sys, wx; print(sys.version); print(wx.version())"
3.11.8 (main, Mar  1 2024, 19:20:20) [GCC 13.2.1 20240113]
4.2.1 gtk3 (phoenix) wxWidgets 3.2.2.1

[tmszi]

I'm testing this PR again, without mentioned error in comment above. Could @neteler and @echoix join into testing, please (if you have some free time)?

[echoix]

I wasn't set up to do some GUI testing last weekend, sorry