Use ${CC} instead of "cc" for linking on mac

[nilason]

Fixes: #609.

[wenzeslaus]

cc -> ${CC} makes sense and it is indeed consistent with other code, but the configure file is generated from configure.in (one of the few or perhaps the only file generated which is in the repo). It is generated using autoconf-2.13. I don't see this piece in configure.in. We could merge this change, no harm in that, but the next update of configure from configure.in will remove this again.

[wenzeslaus]

I get the SHLIB_LD="cc... even with 2.69 (which is the latest version from 2012). So, patching this afterwards seems to be like the only option for fixing this here, unless somebody has a better idea. Please look at #348 for a replacement of this by CMake.

	*-apple-darwin*)
	    SHLIB_CFLAGS="-fno-common"
	    SHLIB_SUFFIX=".dylib"
	    SHLIB_LD="cc -dynamiclib -compatibility_version \${GRASS_VERSION_MAJOR}.\${GRASS_VERSION_MINOR} -current_version \${GRASS_VERSION_MAJOR}.\${GRASS_VERSION_MINOR} -install_name \${INST_DIR}/lib/lib\${LIB_NAME}\${SHLIB_SUFFIX}"
	    LD_LIBRARY_PATH_VAR="DYLD_LIBRARY_PATH"
	    ;;

[ryandesign]

Since configure is a generated file, the problem needs to be fixed in the file from which it is generated, which is aclocal.m4.

[neteler]

Since configure is a generated file, the problem needs to be fixed in the file from which it is generated, which is aclocal.m4.

Yes, here:

grass/aclocal.m4

Line 513 in 6956d2b

SHLIB_LD="cc -dynamiclib -compatibility_version \${GRASS_VERSION_MAJOR}.\${GRASS_VERSION_MINOR} -current_version \${GRASS_VERSION_MAJOR}.\${GRASS_VERSION_MINOR} -install_name \${INST_DIR}/lib/lib\${LIB_NAME}\${SHLIB_SUFFIX}"

[nilason]

Thanks a lot to all of you, really appreciate it. Pushed changes to aclocal.m4 too.

[wenzeslaus]

OK, now it makes sense to me. I don't see any further occurrences of this with grep -IrnE "SHLIB_LD[^a-z]*cc". Unless somebody adds another review or comment raising some new issues, I'm going to merge this soon. Thanks @nilason, @neteler and @ryandesign.

[wenzeslaus]

The failed Python code check is unrelated to this PR and already fixed on master (new version of Flake8 was released catching more errors). The fails on master after merging this are unrelated too (Failed to fetch https://packages.microsoft.com/ubuntu...).

[nilason]

@neteler Please backport this before 7.8.4.

[neteler]

@neteler Please backport this before 7.8.4.

Sure: done.